Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: ui/events/event_handler.cc

Issue 395563002: Make RootView::DispatchGestureEvent() non-virtual (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed nit Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/event.cc ('k') | ui/views/controls/menu/menu_host_root_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/event_handler.cc
diff --git a/ui/events/event_handler.cc b/ui/events/event_handler.cc
index 243007a5553d64f52d830bb03d0ab4aed8bb5df4..0f79c3556fb477e3cffda4d75920fe9cc767101b 100644
--- a/ui/events/event_handler.cc
+++ b/ui/events/event_handler.cc
@@ -21,6 +21,8 @@ EventHandler::~EventHandler() {
}
void EventHandler::OnEvent(Event* event) {
+ // TODO(tdanderson): Encapsulate static_casts in ui::Event for all
+ // event types.
if (event->IsKeyEvent())
OnKeyEvent(static_cast<KeyEvent*>(event));
else if (event->IsMouseEvent())
@@ -30,7 +32,7 @@ void EventHandler::OnEvent(Event* event) {
else if (event->IsTouchEvent())
OnTouchEvent(static_cast<TouchEvent*>(event));
else if (event->IsGestureEvent())
- OnGestureEvent(static_cast<GestureEvent*>(event));
+ OnGestureEvent(event->AsGestureEvent());
else if (event->type() == ET_CANCEL_MODE)
OnCancelMode(static_cast<CancelModeEvent*>(event));
}
« no previous file with comments | « ui/events/event.cc ('k') | ui/views/controls/menu/menu_host_root_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698