Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 395543003: [Android] Fix and re-enable heap_profiler unittests. (Closed)

Created:
6 years, 5 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
navabi1
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, bulach, aurimas (slooooooooow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix and re-enable heap_profiler unittests. This fixes the breakage on the 64-bit build that caused the revert in crrev.com/386073002. This also re-enables tests originally introduced by crrev.com/351183003. TBRing since the original CL was aready LGTM and the fix on top is trivial. BUG=382489 NOTRY=true TBR=navabi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/heap_profiler/heap_profiler_unittest.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 5 months ago (2014-07-14 20:50:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/395543003/1
6 years, 5 months ago (2014-07-14 20:53:12 UTC) #2
navabi1
lgtm
6 years, 5 months ago (2014-07-15 00:12:56 UTC) #3
Primiano Tucci (use gerrit)
The CQ bit was unchecked by primiano@chromium.org
6 years, 5 months ago (2014-07-15 00:16:07 UTC) #4
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 5 months ago (2014-07-15 00:16:24 UTC) #5
Primiano Tucci (use gerrit)
On 2014/07/15 00:16:07, Primiano Tucci wrote: > The CQ bit was unchecked by mailto:primiano@chromium.org Adding ...
6 years, 5 months ago (2014-07-15 00:17:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/395543003/1
6 years, 5 months ago (2014-07-15 00:19:22 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 00:39:12 UTC) #8
Message was sent while issue was closed.
Change committed as 283109

Powered by Google App Engine
This is Rietveld 408576698