Add DevicePropertiesUpdated to NetworkStateHandlerObserver

chromeos/network/network_state_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_NETWORK_NETWORK_STATE_HANDLER_H_
 #define CHROMEOS_NETWORK_NETWORK_STATE_HANDLER_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 333 matching lines @@
 
   // Helper function to notify observers. Calls CheckDefaultNetworkChanged().
   void OnNetworkConnectionStateChanged(NetworkState* network);
 
   // Notifies observers when the default network or its properties change.
   void NotifyDefaultNetworkChanged(const NetworkState* default_network);
 
   // Notifies observers about changes to |network|.
   void NotifyNetworkPropertiesUpdated(const NetworkState* network);
 
+  // Notifies observers about changes to |device|.

[pneubeck (no reviews), 2014/07/16 20:29:48]

Sounds like all changes should trigger notifications. I'm not sure that ipconfig
changes work already.
Maybe you want to add a notification to UpdateIPConfigProperties(), or adapt
this comment to exclude IPconfig (because the notifcation is already sent
through the default network).

[stevenjb, 2014/07/16 20:51:33]

It's likely going to be redundant since the network should receive an IPConfig
update also, but I would rather be thorough in case somewhere down the line we
add some device specific UI and rely on this, so I added a call for devices to
UpdateIPConfigProperties and explicitly commented for each if these that they
include IPCongig[s] updates. Good catch.

+  void NotifyDevicePropertiesUpdated(const DeviceState* device);
+
   // Called whenever Device.Scanning state transitions to false.
   void ScanCompleted(const std::string& type);
 
   // Returns one technology type for |type|. This technology will be the
   // highest priority technology in the type pattern.
   std::string GetTechnologyForType(const NetworkTypePattern& type) const;
 
   // Returns all the technology types for |type|.
   ScopedVector<std::string> GetTechnologiesForType(
       const NetworkTypePattern& type) const;
@@ skipping 26 matching lines @@
   // Map of network specifiers to guids. Contains an entry for each
   // NetworkState that is not saved in a profile.
   SpecifierGuidMap specifier_guid_map_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkStateHandler);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_NETWORK_NETWORK_STATE_HANDLER_H_