Fixes bug in path handling of analyzer

Fixes bug in path handling of analyzer

Was using os.getcwd when it needs to use options.toplevel_dir

R=mark@chromium.org
BUG=383609
TEST=none

[Mark Mentovai, 2014-07-14 18:10:55]

https://codereview.chromium.org/395483002/diff/1/pylib/gyp/generator/analyzer.py
File pylib/gyp/generator/analyzer.py (right):

https://codereview.chromium.org/395483002/diff/1/pylib/gyp/generator/analyzer...
pylib/gyp/generator/analyzer.py:40: if path.startswith(toplevel_dir):
This should be
  if path == toplevel_dir or path.startswith(toplevel_dir + '/'):

because /home/skyguy shouldn’t be considered to “start with” /home/sky.

[sky, 2014-07-14 19:03:08]

How about this?

[Mark Mentovai, 2014-07-14 19:14:14]

I don’t really think this is so great. You shouldn’t need to add slashes to
paths willy-nilly to fix bugs like this, the code that deals with paths should
be aware that some paths have slashes where others just end. I don’t think that
this properly handles the case where you ask “does /home/sky start with
/home/sky”, for example, because that’ll be transformed to “does /home/sky start
with /home/sky/?” and that’s the wrong question to ask.

[sky, 2014-07-15 00:06:30]

I think my path handling was a bit messed up. Take another look?

[sky, 2014-07-16 14:36:56]

On 2014/07/15 00:06:30, sky wrote:
> I think my path handling was a bit messed up. Take another look?

ping

[Mark Mentovai, 2014-07-16 15:48:42]

https://codereview.chromium.org/395483002/diff/60001/pylib/gyp/generator/anal...
File pylib/gyp/generator/analyzer.py (right):

https://codereview.chromium.org/395483002/diff/60001/pylib/gyp/generator/anal...
pylib/gyp/generator/analyzer.py:93: if target.startswith(toplevel_dir):
I still think this is wrong. Now toplevel_dir will always end with a slash. That
means that if target is “/home/sky” and toplevel_dir is “/home/sky/”, startswith
won’t be true.

https://codereview.chromium.org/395483002/diff/60001/pylib/gyp/generator/anal...
pylib/gyp/generator/analyzer.py:97: base_path = base_path.replace('\\', '/')
This is invalid on non-Windows.

[sky, 2014-07-16 18:26:35]

Hopefully I got it this time around. Take another look?

[Mark Mentovai, 2014-07-16 20:28:17]

https://codereview.chromium.org/395483002/diff/80001/pylib/gyp/generator/anal...
File pylib/gyp/generator/analyzer.py (right):

https://codereview.chromium.org/395483002/diff/80001/pylib/gyp/generator/anal...
pylib/gyp/generator/analyzer.py:99: if os.sep == '\\' and os.altsep == '/':
I think that you should do this part first. Windows paths may have a mix of /
and \ separators. If you only transform them after you check the paths above,
you might be missing cases where the slashes point in different directions.

[sky, 2014-07-16 21:14:55]

https://codereview.chromium.org/395483002/diff/80001/pylib/gyp/generator/anal...
File pylib/gyp/generator/analyzer.py (right):

https://codereview.chromium.org/395483002/diff/80001/pylib/gyp/generator/anal...
pylib/gyp/generator/analyzer.py:99: if os.sep == '\\' and os.altsep == '/':
On 2014/07/16 20:28:17, Mark Mentovai wrote:
> I think that you should do this part first. Windows paths may have a mix of /
> and \ separators. If you only transform them after you check the paths above,
> you might be missing cases where the slashes point in different directions.

Done.

[Mark Mentovai, 2014-07-16 22:41:32]

LGTM