Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3468)

Unified Diff: chrome/browser/signin/signin_error_notifier_ash.cc

Issue 395463005: Make sync/sign-in error notifications actionable on click. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/sync_error_notifier_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_error_notifier_ash.cc
diff --git a/chrome/browser/signin/signin_error_notifier_ash.cc b/chrome/browser/signin/signin_error_notifier_ash.cc
index e99e97bd2ae2f9b968ebc0e21d642c903a35f0f0..aae8e7ca5d1d69f4a651a30c812e19203ebc3188 100644
--- a/chrome/browser/signin/signin_error_notifier_ash.cc
+++ b/chrome/browser/signin/signin_error_notifier_ash.cc
@@ -62,6 +62,8 @@ class SigninNotificationDelegate : public NotificationDelegate {
virtual ~SigninNotificationDelegate();
private:
+ void FixSignIn();
+
// Unique id of the notification.
const std::string id_;
@@ -94,9 +96,22 @@ bool SigninNotificationDelegate::HasClickedListener() {
}
void SigninNotificationDelegate::Click() {
+ FixSignIn();
}
void SigninNotificationDelegate::ButtonClick(int button_index) {
+ FixSignIn();
+}
+
+std::string SigninNotificationDelegate::id() const {
+ return id_;
+}
+
+content::WebContents* SigninNotificationDelegate::GetWebContents() const {
+ return NULL;
+}
+
+void SigninNotificationDelegate::FixSignIn() {
#if defined(OS_CHROMEOS)
chrome::AttemptUserExit();
#else
@@ -116,14 +131,6 @@ void SigninNotificationDelegate::ButtonClick(int button_index) {
#endif
}
-std::string SigninNotificationDelegate::id() const {
- return id_;
-}
-
-content::WebContents* SigninNotificationDelegate::GetWebContents() const {
- return NULL;
-}
-
} // namespace
SigninErrorNotifier::SigninErrorNotifier(SigninErrorController* controller,
« no previous file with comments | « no previous file | chrome/browser/sync/sync_error_notifier_ash.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698