Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 395443002: Run DM on all bots. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Visibility:
Public.

Description

Run DM on all bots. I figure there's a lot of special cases and exemptions we may need to steal from run_tests and run_gm, but might as well for now try as vanilla as possible. BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/0e6fdada778ad14e38b25f8b5827a8b156674045

Patch Set 1 #

Patch Set 2 : reup #

Total comments: 6

Patch Set 3 : add dm to default_build_step_utils.py #

Patch Set 4 : reup #

Patch Set 5 : remove from housekeeper #

Patch Set 6 : cleanup slave #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6506 lines, -115 lines) Patch
M master/skia_master_scripts/factory.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M master/skia_master_scripts/housekeeping_percommit_factory.py View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M slave/skia_slave_scripts/flavor_utils/default_build_step_utils.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M slave/skia_slave_scripts/run_dm.py View 1 2 3 4 5 1 chunk +4 lines, -5 lines 0 comments Download
M tools/tests/factory_configuration/expected/Housekeeper-PerCommit View 1 2 3 4 1 chunk +0 lines, -54 lines 0 comments Download
M tools/tests/factory_configuration/expected/Housekeeper-PerCommit-Trybot View 1 2 3 4 1 chunk +0 lines, -54 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-GalaxyNexus-SGX540-Arm7-Debug View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-GalaxyNexus-SGX540-Arm7-Debug-Trybot View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-GalaxyNexus-SGX540-Arm7-Release View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-GalaxyNexus-SGX540-Arm7-Release-Trybot View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-IntelRhb-SGX544-x86-Debug View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-IntelRhb-SGX544-x86-Debug-Trybot View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-IntelRhb-SGX544-x86-Release View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-IntelRhb-SGX544-x86-Release-Trybot View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Logan-Nvidia-Arm7-Debug View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Logan-Nvidia-Arm7-Debug-Trybot View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Logan-Nvidia-Arm7-Release View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Logan-Nvidia-Arm7-Release-Trybot View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Nexus10-MaliT604-Arm7-Debug View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Nexus10-MaliT604-Arm7-Debug-Trybot View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Nexus10-MaliT604-Arm7-Release View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Nexus10-MaliT604-Arm7-Release-Trybot View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Nexus4-Adreno320-Arm7-Debug View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Nexus4-Adreno320-Arm7-Debug-Trybot View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Nexus4-Adreno320-Arm7-Release View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Nexus4-Adreno320-Arm7-Release-Trybot View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Nexus7-Tegra3-Arm7-Debug View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Nexus7-Tegra3-Arm7-Debug-Trybot View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Nexus7-Tegra3-Arm7-Release View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Nexus7-Tegra3-Arm7-Release-Trybot View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-NexusS-SGX540-Arm7-Debug View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-NexusS-SGX540-Arm7-Debug-Trybot View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-NexusS-SGX540-Arm7-Release View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-NexusS-SGX540-Arm7-Release-Trybot View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Xoom-Tegra2-Arm7-Debug View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Xoom-Tegra2-Arm7-Debug-Trybot View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Xoom-Tegra2-Arm7-Release View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Android-Xoom-Tegra2-Arm7-Release-Trybot View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-ChromeOS-Alex-GMA3150-x86-Debug View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-ChromeOS-Alex-GMA3150-x86-Debug-Trybot View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-ChromeOS-Alex-GMA3150-x86-Release View 1 chunk +60 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-ChromeOS-Alex-GMA3150-x86-Release-Trybot View 1 chunk +60 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug-Trybot View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-ChromeOS-Daisy-MaliT604-Arm7-Release View 1 chunk +60 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-ChromeOS-Daisy-MaliT604-Arm7-Release-Trybot View 1 chunk +60 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-ChromeOS-Link-HD4000-x86_64-Debug View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-ChromeOS-Link-HD4000-x86_64-Debug-Trybot View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-ChromeOS-Link-HD4000-x86_64-Release View 1 chunk +60 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-ChromeOS-Link-HD4000-x86_64-Release-Trybot View 1 chunk +60 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Linux-Bare-NoGPU-Arm64-Debug View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Linux-Bare-NoGPU-Arm64-Debug-Trybot View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Ubuntu12-ShuttleA-GTX660-x86-Release View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Ubuntu12-ShuttleA-GTX660-x86-Release-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN-Trybot View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86-Release View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86-Release-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86_64-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86_64-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86_64-Release View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win7-ShuttleA-HD2000-x86_64-Release-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-GTX660-x86-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-GTX660-x86-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-GTX660-x86-Release View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-GTX660-x86-Release-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-GTX660-x86_64-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-GTX660-x86_64-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-GTX660-x86_64-Release View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-GTX660-x86_64-Release-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-HD7770-x86-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-HD7770-x86-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-HD7770-x86-Release View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-HD7770-x86-Release-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-HD7770-x86_64-Debug View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-HD7770-x86_64-Debug-Trybot View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-HD7770-x86_64-Release View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/tests/factory_configuration/expected/Test-Win8-ShuttleA-HD7770-x86_64-Release-Trybot View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
Let's revive this idea? We can iterate quickly on run_dm.py if it's breaking too much, ...
6 years, 5 months ago (2014-07-14 15:18:22 UTC) #1
borenet
https://codereview.chromium.org/395443002/diff/2/master/skia_master_scripts/factory.py File master/skia_master_scripts/factory.py (right): https://codereview.chromium.org/395443002/diff/2/master/skia_master_scripts/factory.py#newcode705 master/skia_master_scripts/factory.py:705: self.RunDM() We can probably remove this from the Housekeeper ...
6 years, 5 months ago (2014-07-14 19:53:48 UTC) #2
mtklein
Have another look? https://codereview.chromium.org/395443002/diff/2/master/skia_master_scripts/factory.py File master/skia_master_scripts/factory.py (right): https://codereview.chromium.org/395443002/diff/2/master/skia_master_scripts/factory.py#newcode705 master/skia_master_scripts/factory.py:705: self.RunDM() On 2014/07/14 19:53:47, borenet wrote: ...
6 years, 5 months ago (2014-07-14 20:39:47 UTC) #3
borenet
LGTM at patch set 6.
6 years, 5 months ago (2014-07-14 20:43:17 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-14 20:45:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/395443002/80001
6 years, 5 months ago (2014-07-14 20:45:57 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 20:46:51 UTC) #7
Message was sent while issue was closed.
Change committed as 0e6fdada778ad14e38b25f8b5827a8b156674045

Powered by Google App Engine
This is Rietveld 408576698