src/x64/full-codegen-x64.cc - Issue 39543003: Refactor loading a pointer and loading an integer64 into a register instructions for X64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 39543003: Refactor loading a pointer and loading an integer64 into a register instructions for X64 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Make movq(Register, int64_t) an assembler instruction for 64-bit integer only" Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index 02ba67b90e3511f8943b927f1c7ad571ef44df08..a5d1d480253aa636bba1eb4838b514cc5767f500 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -315,9 +315,7 @@ void FullCodeGenerator::EmitProfilingCounterReset() {

reset_value = Smi::kMaxValue;

}

__ movq(rbx, profiling_counter_, RelocInfo::EMBEDDED_OBJECT);

- __ movq(kScratchRegister,

- reinterpret_cast<uint64_t>(Smi::FromInt(reset_value)),

- RelocInfo::NONE64);

+ __ Move(kScratchRegister, Smi::FromInt(reset_value));

__ movq(FieldOperand(rbx, Cell::kValueOffset), kScratchRegister);

}

« src/x64/assembler-x64.cc ('K') | « src/x64/codegen-x64.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »