Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: build/common.gypi

Issue 395403002: Remove win_third_party_warn_as_error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 1222 matching lines...) Expand 10 before | Expand all | Expand 10 after
1233 # to get incremental linking to be faster in debug builds. 1233 # to get incremental linking to be faster in debug builds.
1234 'incremental_chrome_dll%': '0', 1234 'incremental_chrome_dll%': '0',
1235 1235
1236 # Experimental setting to break chrome.dll into multiple pieces based on 1236 # Experimental setting to break chrome.dll into multiple pieces based on
1237 # process type. 1237 # process type.
1238 'chrome_multiple_dll%': '0', 1238 'chrome_multiple_dll%': '0',
1239 1239
1240 # Experimental setting to optimize Chrome's DLLs with PGO. 1240 # Experimental setting to optimize Chrome's DLLs with PGO.
1241 'chrome_pgo_phase%': '0', 1241 'chrome_pgo_phase%': '0',
1242 1242
1243 # The default settings for third party code for treating
1244 # warnings-as-errors. Ideally, this would not be required, however there
1245 # is some third party code that takes a long time to fix/roll. So, this
1246 # flag allows us to have warnings as errors in general to prevent
1247 # regressions in most modules, while working on the bits that are
1248 # remaining.
1249 'win_third_party_warn_as_error%': 'true',
1250
1251 # Clang stuff. 1243 # Clang stuff.
1252 'clang%': '<(clang)', 1244 'clang%': '<(clang)',
1253 'make_clang_dir%': 'third_party/llvm-build/Release+Asserts', 1245 'make_clang_dir%': 'third_party/llvm-build/Release+Asserts',
1254 1246
1255 # Control which version of clang to use when building for iOS. If set to 1247 # Control which version of clang to use when building for iOS. If set to
1256 # '1', uses the version of clang that ships with Xcode. If set to '0', uses 1248 # '1', uses the version of clang that ships with Xcode. If set to '0', uses
1257 # the version of clang that ships with the Chromium source. This variable 1249 # the version of clang that ships with the Chromium source. This variable
1258 # is automatically set to '1' when using the Xcode generator. 1250 # is automatically set to '1' when using the Xcode generator.
1259 'clang_xcode%': 0, 1251 'clang_xcode%': 0,
1260 1252
(...skipping 1682 matching lines...) Expand 10 before | Expand all | Expand 10 after
2943 'defines': [ 2935 'defines': [
2944 '_CRT_SECURE_NO_DEPRECATE', 2936 '_CRT_SECURE_NO_DEPRECATE',
2945 '_CRT_NONSTDC_NO_WARNINGS', 2937 '_CRT_NONSTDC_NO_WARNINGS',
2946 '_CRT_NONSTDC_NO_DEPRECATE', 2938 '_CRT_NONSTDC_NO_DEPRECATE',
2947 '_SCL_SECURE_NO_DEPRECATE', 2939 '_SCL_SECURE_NO_DEPRECATE',
2948 ], 2940 ],
2949 'msvs_disabled_warnings': [4800], 2941 'msvs_disabled_warnings': [4800],
2950 'msvs_settings': { 2942 'msvs_settings': {
2951 'VCCLCompilerTool': { 2943 'VCCLCompilerTool': {
2952 'WarningLevel': '3', 2944 'WarningLevel': '3',
2953 'WarnAsError': '<(win_third_party_warn_as_error)', 2945 'WarnAsError': 'true',
2954 'Detect64BitPortabilityProblems': 'false', 2946 'Detect64BitPortabilityProblems': 'false',
2955 }, 2947 },
2956 }, 2948 },
2957 'conditions': [ 2949 'conditions': [
2958 ['buildtype=="Official"', { 2950 ['buildtype=="Official"', {
2959 'msvs_settings': { 2951 'msvs_settings': {
2960 'VCCLCompilerTool': { 'WarnAsError': 'false' }, 2952 'VCCLCompilerTool': { 'WarnAsError': 'false' },
2961 } 2953 }
2962 }], 2954 }],
2963 ['clang==1', { 2955 ['clang==1', {
(...skipping 2691 matching lines...) Expand 10 before | Expand all | Expand 10 after
5655 # settings in target dicts. SYMROOT is a special case, because many other 5647 # settings in target dicts. SYMROOT is a special case, because many other
5656 # Xcode variables depend on it, including variables such as 5648 # Xcode variables depend on it, including variables such as
5657 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5649 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5658 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5650 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5659 # files to appear (when present) in the UI as actual files and not red 5651 # files to appear (when present) in the UI as actual files and not red
5660 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5652 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5661 # and therefore SYMROOT, needs to be set at the project level. 5653 # and therefore SYMROOT, needs to be set at the project level.
5662 'SYMROOT': '<(DEPTH)/xcodebuild', 5654 'SYMROOT': '<(DEPTH)/xcodebuild',
5663 }, 5655 },
5664 } 5656 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698