Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 395393002: Add adb version check to adb_remote_setup.sh. (Closed)

Created:
6 years, 5 months ago by newt (away)
Modified:
6 years, 5 months ago
Reviewers:
Jay Civelli
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add adb version check to adb_remote_setup.sh. This ensures that the local and remote versions of adb are the same, since using different versions of adb will probably result in protocol errors. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284181

Patch Set 1 #

Patch Set 2 : made warning more prominent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M tools/android/adb_remote_setup.sh View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
newt (away)
This should do the trick. I haven't tested it yet though.
6 years, 5 months ago (2014-07-17 02:14:54 UTC) #1
Jay Civelli
lgtm
6 years, 5 months ago (2014-07-17 22:12:13 UTC) #2
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 5 months ago (2014-07-18 19:19:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/395393002/20001
6 years, 5 months ago (2014-07-18 19:22:30 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 19:24:28 UTC) #5
Message was sent while issue was closed.
Change committed as 284181

Powered by Google App Engine
This is Rietveld 408576698