Issue 395333004: [SyncFS] Clear sync task runners on shutdown of SyncFileSystemService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 395333004: [SyncFS] Clear sync task runners on shutdown of SyncFileSystemService (Closed)

Created:
6 years, 5 months ago by tzik

Modified:
6 years, 5 months ago

Reviewers:
peria

CC:
chromium-reviews, tzik, nhiroki, timurrrr+watch_chromium.org, glider+watch_chromium.org, kinuko+fileapi, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[SyncFS] Clear sync task runners on shutdown of SyncFileSystemService This CL should fix a memory corruption in a unit_tests which is recently introduced. That is caused by sync task invocation after SyncFileSystemService::Shutdown. BUG=394460 TEST=unit_tests --gtest_filter='SyncFileSystemServiceTest.*' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283756

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -4 lines)			Patch
M	chrome/browser/sync_file_system/sync_file_system_service.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
D	tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	tools/valgrind/gtest_exclude/unit_tests.gtest-memcheck_linux.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

peria

Code LGTM. Could you add a short explanation what was the reason of the test ...

6 years, 5 months ago (2014-07-17 08:08:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/395333004/1

6 years, 5 months ago (2014-07-17 08:18:12 UTC) #4

Message was sent while issue was closed.

Change committed as 283756

Expand Messages | Collapse Messages