Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 395303003: Fix a few stray net::'s in net/socket/ (Closed)

Created:
6 years, 5 months ago by davidben
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix a few stray net::'s in net/socket/ BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -90 lines) Patch
M net/socket/client_socket_pool_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/server_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_openssl_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 23 chunks +74 lines, -76 lines 0 comments Download
M net/socket/tcp_server_socket_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/socket/transport_client_socket_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/websocket_transport_client_socket_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
davidben
As requested. I had a much more aggressive one, but the existence of NetLog() methods ...
6 years, 5 months ago (2014-07-16 21:35:23 UTC) #1
Ryan Sleevi
Thanks for the quick fix! LGTM
6 years, 5 months ago (2014-07-16 21:44:05 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-16 21:46:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/395303003/1
6 years, 5 months ago (2014-07-16 21:48:50 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 04:27:08 UTC) #5
Message was sent while issue was closed.
Change committed as 283642

Powered by Google App Engine
This is Rietveld 408576698