Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 395253003: [MemSheriff] Suppress broken test. (Closed)

Created:
6 years, 5 months ago by groby-ooo-7-16
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[MemSheriff] Suppress broken test. BUG=394460 TBR=thestig@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283577

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove copy/paste debris #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
A tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A tools/valgrind/gtest_exclude/unit_tests.gtest-memcheck_linux.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
groby-ooo-7-16
6 years, 5 months ago (2014-07-16 19:32:07 UTC) #1
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 5 months ago (2014-07-16 19:32:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/395253003/1
6 years, 5 months ago (2014-07-16 19:34:34 UTC) #3
Lei Zhang
https://codereview.chromium.org/395253003/diff/1/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory.txt File tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory.txt (right): https://codereview.chromium.org/395253003/diff/1/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory.txt#newcode1 tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory.txt:1: # Flaky, see http://crbug.com/394460 [0/9408] copy paste error? https://codereview.chromium.org/395253003/diff/1/tools/valgrind/gtest_exclude/unit_tests.gtest-memcheck_linux.txt ...
6 years, 5 months ago (2014-07-16 19:40:13 UTC) #4
groby-ooo-7-16
The CQ bit was unchecked by groby@chromium.org
6 years, 5 months ago (2014-07-16 19:42:30 UTC) #5
groby-ooo-7-16
Good thing the tree is throttled, and thanks for noticing!
6 years, 5 months ago (2014-07-16 19:42:46 UTC) #6
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 5 months ago (2014-07-16 19:50:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/395253003/20001
6 years, 5 months ago (2014-07-16 19:52:00 UTC) #8
Lei Zhang
lgtm++
6 years, 5 months ago (2014-07-16 20:44:48 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 23:35:55 UTC) #10
Message was sent while issue was closed. 
Change committed as 283577

Powered by Google App Engine
This is Rietveld 408576698