Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 395253002: Fix unsigned comparison in previousIfPositionIsAfterLineBreak (Closed)

Created:
6 years, 5 months ago by rwlbuis
Modified:
6 years, 5 months ago
Reviewers:
tkent, yoichio
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix unsigned comparison in previousIfPositionIsAfterLineBreak Fix unsigned comparison in previousIfPositionIsAfterLineBreak, the unsigned can't be negative so don't test for it. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
rwlbuis
PTAL
6 years, 5 months ago (2014-07-16 19:48:29 UTC) #1
tkent
+yoichio
6 years, 5 months ago (2014-07-16 23:52:24 UTC) #2
yoichio
lgtm Nice catch!
6 years, 5 months ago (2014-07-17 01:47:59 UTC) #3
tkent
rslgtm
6 years, 5 months ago (2014-07-17 01:51:11 UTC) #4
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 5 months ago (2014-07-17 01:51:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/395253002/1
6 years, 5 months ago (2014-07-17 01:52:38 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-17 03:06:00 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 03:59:00 UTC) #8
Message was sent while issue was closed.
Change committed as 178312

Powered by Google App Engine
This is Rietveld 408576698