Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 395223002: Remove some TODOs related to event targeting in views (Closed)

Created:
6 years, 5 months ago by tdanderson
Modified:
6 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove some TODOs related to event targeting in views Removes some obsolete TODOs from the code. BUG=355425 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283796

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M ui/views/view.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/view_targeter_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tdanderson
Sadrul, can you PTAL?
6 years, 5 months ago (2014-07-16 17:26:34 UTC) #1
sadrul
lgtm
6 years, 5 months ago (2014-07-16 20:10:08 UTC) #2
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 5 months ago (2014-07-16 20:40:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/395223002/20001
6 years, 5 months ago (2014-07-16 20:42:38 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 02:28:58 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 03:16:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/28837)
6 years, 5 months ago (2014-07-17 03:16:44 UTC) #7
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 5 months ago (2014-07-17 15:38:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/395223002/20001
6 years, 5 months ago (2014-07-17 15:40:06 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-17 16:12:21 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 16:38:12 UTC) #11
Message was sent while issue was closed. 
Change committed as 283796

Powered by Google App Engine
This is Rietveld 408576698