src/IceTargetLoweringX8632.cpp - Issue 395193005: Start processing function blocks in Subzero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8632.cpp

Issue 395193005: Start processing function blocks in Subzero. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nits in patch set 4. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX8632.cpp

diff --git a/src/IceTargetLoweringX8632.cpp b/src/IceTargetLoweringX8632.cpp

index af9ebc5a1dc79f02a42d83abc454ec12fb9ad874..f2fb5f10b31d049b6aa9ec1b72e615297801dc25 100644

--- a/src/IceTargetLoweringX8632.cpp

+++ b/src/IceTargetLoweringX8632.cpp

@@ -200,7 +200,7 @@ void xMacroIntegrityCheck() {

_num

};

// Define a set of constants based on high-level table entries.

-#define X(tag, size, align, elts, elty, str) \

+#define X(tag, size, align, elts, elty, str, flags) \

jvoung (off chromium) 2014/07/22 18:40:18 "\" for continuation can go near 80 col mark for c

Karl 2014/07/23 20:22:20 Done.

static const int _table1_##tag = tag;

ICETYPE_TABLE;

#undef X

@@ -213,7 +213,7 @@ void xMacroIntegrityCheck() {

#undef X

// Repeat the static asserts with respect to the high-level

// table entries in case the high-level table has extra entries.

-#define X(tag, size, align, elts, elty, str) \

+#define X(tag, size, align, elts, elty, str, flags) \

jvoung (off chromium) 2014/07/22 18:40:18 same

Karl 2014/07/23 20:22:20 Done.

STATIC_ASSERT(_table1_##tag == _table2_##tag);

ICETYPE_TABLE;

#undef X

« src/IceConverter.cpp ('K') | « src/IceInst.cpp ('k') | src/IceTranslator.h » ('j') | src/IceTypes.cpp » ('J')