Create a cross-platform helper class for badging the wrench menu.

Create a cross-platform helper class for badging the wrench menu. 

Adds WrenchMenuBadgeController which is responsible for notifying toolbar 
UI implementations (i.e. views and cocoa) about how they should be badged. 

Logic is moved from Cocoa and Views toolbar implementations and from 
wrench_icon_painter.cc to this new class. 

This refactor allows to easily expand the functionality of this class to add 
new sources of badging without needing to make the same changes to 
several platform-specific implementations. 

No functional changes. 

BUG=394855
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284084

[Alexei Svitkine (slow), 2014-07-17 19:26:09]

finnur: overall review
sky: toolbar_view.cc and owners review

[sky, 2014-07-17 19:54:28]

LGTM

https://codereview.chromium.org/395193003/diff/80001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/wrench_menu_badge_controller.h (right):

https://codereview.chromium.org/395193003/diff/80001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/wrench_menu_badge_controller.h:21: enum BadgeType {
nit: use enum names as described for content, eg BAGE_TYPE_NONE...

https://codereview.chromium.org/395193003/diff/80001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/wrench_menu_badge_controller.h:37: };
add protected virtual constructor to make ownership clearer.

https://codereview.chromium.org/395193003/diff/80001/chrome/browser/ui/views/...
File chrome/browser/ui/views/toolbar/toolbar_view.cc (right):

https://codereview.chromium.org/395193003/diff/80001/chrome/browser/ui/views/...
chrome/browser/ui/views/toolbar/toolbar_view.cc:716: SchedulePaint();
I realize you're copying code here, but it seems like this SchedulePaint only
matters for app_menu_. I think the SchedulePaint should be moved to
WrenchToolbarButton::SetSeverity.

[Alexei Svitkine (slow), 2014-07-17 21:35:29]

https://codereview.chromium.org/395193003/diff/80001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/wrench_menu_badge_controller.h (right):

https://codereview.chromium.org/395193003/diff/80001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/wrench_menu_badge_controller.h:21: enum BadgeType {
On 2014/07/17 19:54:28, sky wrote:
> nit: use enum names as described for content, eg BAGE_TYPE_NONE...

Done.

https://codereview.chromium.org/395193003/diff/80001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/wrench_menu_badge_controller.h:37: };
On 2014/07/17 19:54:28, sky wrote:
> add protected virtual constructor to make ownership clearer.

Done.

https://codereview.chromium.org/395193003/diff/80001/chrome/browser/ui/views/...
File chrome/browser/ui/views/toolbar/toolbar_view.cc (right):

https://codereview.chromium.org/395193003/diff/80001/chrome/browser/ui/views/...
chrome/browser/ui/views/toolbar/toolbar_view.cc:716: SchedulePaint();
On 2014/07/17 19:54:28, sky wrote:
> I realize you're copying code here, but it seems like this SchedulePaint only
> matters for app_menu_. I think the SchedulePaint should be moved to
> WrenchToolbarButton::SetSeverity.

Done.

[Finnur, 2014-07-18 11:14:17]

Neat.

LGTM

[Alexei Svitkine (slow), 2014-07-18 12:38:25]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2014-07-18 12:39:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/asvitkine@chromium.org/395193003/100001

[commit-bot: I haz the power, 2014-07-18 14:02:05]

Change committed as 284084