Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 395153003: v8: fix tracking of longest_step in IncrementalMarking. (Closed)

Created:
6 years, 5 months ago by ernstm
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

v8: fix tracking of longest_step in IncrementalMarking. longest_step is only output at the end of a mark-compact. We shouldn't reset it after a Scavenge. R=hpayer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22432

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/incremental-marking.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
ernstm
PTAL
6 years, 5 months ago (2014-07-16 12:01:57 UTC) #1
Hannes Payer (out of office)
lgtm
6 years, 5 months ago (2014-07-16 12:50:26 UTC) #2
ernstm
The CQ bit was checked by ernstm@chromium.org
6 years, 5 months ago (2014-07-16 13:07:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/ernstm@chromium.org/395153003/1
6 years, 5 months ago (2014-07-16 13:08:13 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 13:08:14 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-16 13:08:15 UTC) #6
ernstm
6 years, 5 months ago (2014-07-16 13:19:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r22432 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698