Make FileReader's throttle controller a supplement.

Make FileReader's throttle controller a supplement.

Avoid using thread-local state to hold the per-ExecutionContext instance
of this controller object.

By doing so, we can also move the controller object to the heap with
Oilpan, enabling the tracing of the collections that the controller
keeps.

R=haraken@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178274

[sof, 2014-07-16 10:43:21]

Please take a look.

[haraken, 2014-07-16 11:37:26]

LGTM

https://codereview.chromium.org/395143002/diff/1/Source/core/fileapi/FileRead...
File Source/core/fileapi/FileReader.cpp (right):

https://codereview.chromium.org/395143002/diff/1/Source/core/fileapi/FileRead...
Source/core/fileapi/FileReader.cpp:96: ASSERT(context->isWorkerGlobalScope());

Also add ASSERT(!isMainThread()).

https://codereview.chromium.org/395143002/diff/1/Source/core/fileapi/FileRead...
Source/core/fileapi/FileReader.cpp:174: static const char* supplementName() {
return "FileReaderThrottleController"; }

"FileReaderThrottlingController"

[sof, 2014-07-16 11:46:20]

Thanks for the review; a fun change.

https://codereview.chromium.org/395143002/diff/1/Source/core/fileapi/FileRead...
File Source/core/fileapi/FileReader.cpp (right):

https://codereview.chromium.org/395143002/diff/1/Source/core/fileapi/FileRead...
Source/core/fileapi/FileReader.cpp:96: ASSERT(context->isWorkerGlobalScope());
On 2014/07/16 11:37:26, haraken wrote:
> 
> Also add ASSERT(!isMainThread()).

Done.

https://codereview.chromium.org/395143002/diff/1/Source/core/fileapi/FileRead...
Source/core/fileapi/FileReader.cpp:174: static const char* supplementName() {
return "FileReaderThrottleController"; }
On 2014/07/16 11:37:26, haraken wrote:
> 
> "FileReaderThrottlingController"

Fixed.

[sof, 2014-07-16 11:46:27]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-07-16 11:46:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sigbjornf@opera.com/395143002/20001

[commit-bot: I haz the power, 2014-07-16 13:18:50]

Change committed as 178274

[kinuko, 2014-07-16 16:03:00]

lgtm, thx (cc-ing horo@)