Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 395133002: Clean up. Experimental user avatars removed. (Closed)

Created:
6 years, 5 months ago by merkulova
Modified:
6 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More removal. #

Patch Set 3 : Rebase. #

Patch Set 4 : Libvpx roll. #

Patch Set 5 : Libvpx update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -658 lines) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/user_images_grid.js View 1 2 3 4 chunks +1 line, -57 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 1 2 3 3 chunks +5 lines, -37 lines 0 comments Download
M components/user_manager/user.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M components/user_manager/user_image/user_image.h View 1 4 chunks +1 line, -11 lines 0 comments Download
M components/user_manager/user_image/user_image.cc View 1 3 chunks +2 lines, -25 lines 0 comments Download
M media/BUILD.gn View 1 2 3 1 chunk +0 lines, -21 lines 0 comments Download
D media/formats/webm/chromeos/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D media/formats/webm/chromeos/ebml_writer.h View 1 chunk +0 lines, -21 lines 0 comments Download
D media/formats/webm/chromeos/ebml_writer.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D media/formats/webm/chromeos/webm_encoder.h View 1 chunk +0 lines, -106 lines 0 comments Download
D media/formats/webm/chromeos/webm_encoder.cc View 1 chunk +0 lines, -321 lines 0 comments Download
M media/media.gyp View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 38 (0 generated)
Nikita (slow)
There's more related code in user_manager::UserImage like // Optional raw representation of the animated image. ...
6 years, 5 months ago (2014-07-16 10:57:54 UTC) #1
merkulova
Digged around for unused.
6 years, 5 months ago (2014-07-21 08:38:40 UTC) #2
Nikita (slow)
lgtm
6 years, 5 months ago (2014-07-21 09:17:17 UTC) #3
scherkus (not reviewing)
lgtm
6 years, 5 months ago (2014-07-21 17:27:01 UTC) #4
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 5 months ago (2014-07-21 19:41:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/395133002/20001
6 years, 5 months ago (2014-07-21 19:43:51 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 20:18:43 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 20:20:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/29463) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/31181)
6 years, 5 months ago (2014-07-21 20:20:15 UTC) #9
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 5 months ago (2014-07-22 07:39:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/395133002/40001
6 years, 5 months ago (2014-07-22 07:40:52 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 09:33:51 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 10:10:50 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/41482)
6 years, 5 months ago (2014-07-22 10:10:51 UTC) #14
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 5 months ago (2014-07-22 10:12:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/395133002/40001
6 years, 5 months ago (2014-07-22 10:13:00 UTC) #16
commit-bot: I haz the power
Change committed as 284666
6 years, 5 months ago (2014-07-22 12:05:14 UTC) #17
johnme
A revert of this CL has been created in https://codereview.chromium.org/411523005/ by johnme@chromium.org. The reason for ...
6 years, 5 months ago (2014-07-22 14:41:20 UTC) #18
merkulova
+fgalligan for libvpx revision update
6 years, 4 months ago (2014-07-28 17:20:38 UTC) #19
fgalligan1
On 2014/07/28 17:20:38, merkulova wrote: > +fgalligan for libvpx revision update lgtm
6 years, 4 months ago (2014-07-28 17:22:29 UTC) #20
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 4 months ago (2014-07-28 17:28:40 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/395133002/60001
6 years, 4 months ago (2014-07-28 17:30:39 UTC) #22
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-28 20:36:53 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 20:45:40 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_clang_dbg/builds/411) linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/538)
6 years, 4 months ago (2014-07-28 20:45:41 UTC) #25
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 4 months ago (2014-07-30 06:33:19 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/395133002/80001
6 years, 4 months ago (2014-07-30 06:33:53 UTC) #27
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-07-30 09:50:59 UTC) #28
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 10:45:00 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/1375)
6 years, 4 months ago (2014-07-30 10:45:02 UTC) #30
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 4 months ago (2014-07-30 16:47:33 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/395133002/80001
6 years, 4 months ago (2014-07-30 16:49:11 UTC) #32
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-07-30 16:59:58 UTC) #33
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 17:39:50 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/1479)
6 years, 4 months ago (2014-07-30 17:39:50 UTC) #35
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 4 months ago (2014-07-30 20:26:03 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/395133002/80001
6 years, 4 months ago (2014-07-30 20:59:40 UTC) #37
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 00:51:49 UTC) #38
Message was sent while issue was closed.
Change committed as 286661

Powered by Google App Engine
This is Rietveld 408576698