Use scoped_refptr for refcounted param in SafeBrowsingService.

Use scoped_refptr for refcounted param in SafeBrowsingService.

BUG=28083
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63215

[willchan no longer on Chromium, 2010-10-20 16:19:24]

Um oops, I committed the wrong cl.  Lei, it's a very simple change.  Lemme know
if you disagree and I'll revert.  Sorry for landing without your review.

On 2010/10/20 06:47:47, willchan wrote:
>

[lzheng, 2010-10-20 18:03:55]

http://codereview.chromium.org/3951001/diff/1/2
File chrome/browser/safe_browsing/safe_browsing_service.cc (right):

http://codereview.chromium.org/3951001/diff/1/2#newcode349
chrome/browser/safe_browsing/safe_browsing_service.cc:349:
URLRequestContextGetter* request_context_getter) {
Should this become scoped_refptr<URLRequestContextGetter>?

[willchan no longer on Chromium, 2010-10-20 18:06:49]

http://codereview.chromium.org/3951001/diff/1/2
File chrome/browser/safe_browsing/safe_browsing_service.cc (right):

http://codereview.chromium.org/3951001/diff/1/2#newcode349
chrome/browser/safe_browsing/safe_browsing_service.cc:349:
URLRequestContextGetter* request_context_getter) {
On 2010/10/20 18:03:55, lzheng wrote:
> Should this become scoped_refptr<URLRequestContextGetter>?

Not necessary, and there was a chromium-dev discussion where the majority of
people prefer that it is passed as a raw pointer.  The scoped_refptr is just to
make sure that the RunnableMethod task will have a Tuple that uses a
scoped_refptr, so the parameter will be guaranteed to be valid for the lifetime
of this function call.

It's sort of complicated.  Read the bug thread for details on the nature of the
bug.

[lzheng1, 2010-10-20 19:00:44]

LGTM

On Wed, Oct 20, 2010 at 11:06 AM, <willchan@chromium.org> wrote:

>
> http://codereview.chromium.org/3951001/diff/1/2
> File chrome/browser/safe_browsing/safe_browsing_service.cc (right):
>
> http://codereview.chromium.org/3951001/diff/1/2#newcode349
> chrome/browser/safe_browsing/safe_browsing_service.cc:349:
> URLRequestContextGetter* request_context_getter) {
> On 2010/10/20 18:03:55, lzheng wrote:
>
>> Should this become scoped_refptr<URLRequestContextGetter>?
>>
>
> Not necessary, and there was a chromium-dev discussion where the
> majority of people prefer that it is passed as a raw pointer.  The
> scoped_refptr is just to make sure that the RunnableMethod task will
> have a Tuple that uses a scoped_refptr, so the parameter will be
> guaranteed to be valid for the lifetime of this function call.
>
> It's sort of complicated.  Read the bug thread for details on the nature
> of the bug.
>
>
> http://codereview.chromium.org/3951001/show
>

Thanks for the pointer. So, the cast to T* happens during callback time
which makes the code safe.

Lei