Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 395093002: Remove RenderFrameImpl::willRequestAfterPreconnect (Closed)

Created:
6 years, 5 months ago by kouhei (in TOK)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove RenderFrameImpl::willRequestAfterPreconnect |willRequestAfterPreconnect| was removed from blink::WebFrameClient at blink r178134, thus this override is never called. BUG=386888 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283544

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kouhei (in TOK)
Would you take a look?
6 years, 5 months ago (2014-07-16 07:08:43 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-16 08:58:04 UTC) #2
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 5 months ago (2014-07-16 10:19:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/395093002/1
6 years, 5 months ago (2014-07-16 10:20:23 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 14:34:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 14:55:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171539)
6 years, 5 months ago (2014-07-16 14:55:44 UTC) #7
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 5 months ago (2014-07-16 15:06:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/395093002/1
6 years, 5 months ago (2014-07-16 15:07:33 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 15:28:39 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 22:18:31 UTC) #11
Message was sent while issue was closed.
Change committed as 283544

Powered by Google App Engine
This is Rietveld 408576698