Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 395023003: webkit: Remove inspector_strings.grd file. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin (slow to review), jam, pilgrim_google, jochen (gone - plz use gerrit)
Project:
chromium
Visibility:
Public.

Description

webkit: Remove inspector_strings.grd file. It is unused, so we just delete it. BUG=338338 TEST=None R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283976

Patch Set 1 #

Patch Set 2 : rm DEPS as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1480 lines) Patch
M tools/gritsettings/resource_ids View 1 chunk +0 lines, -3 lines 0 comments Download
D webkit/glue/DEPS View 1 1 chunk +0 lines, -13 lines 0 comments Download
D webkit/glue/inspector_strings.grd View 1 chunk +0 lines, -1464 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
6 years, 5 months ago (2014-07-17 00:59:40 UTC) #1
jamesr
Cool! lgtm
6 years, 5 months ago (2014-07-17 20:30:19 UTC) #2
tfarina
Committed patchset #2 manually as r283976 (presubmit successful).
6 years, 5 months ago (2014-07-18 02:31:51 UTC) #3
PhistucK
6 years, 5 months ago (2014-07-18 21:58:00 UTC) #4
Message was sent while issue was closed.
The LaunchPad translation console includes these string (perhaps from a
different GRD?), are we sure it is unused?

Powered by Google App Engine
This is Rietveld 408576698