Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc

Issue 395013002: Pass signin_scoped_device_id to DeviceInfoSpecifics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Revers chrome_signin_client Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc
diff --git a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc
index 8b475fb549a9309c096cf259fe51c67239ff5b2f..f98b95454a56d9a8b686bf0ebfe1c7619e76c5ca 100644
--- a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc
+++ b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc
@@ -39,15 +39,19 @@ TEST(SignedInDevicesAPITest, GetSignedInDevices) {
scoped_refptr<Extension> extension_test =
extension_prefs.AddExtension(extension_name);
- DeviceInfo device_info1(
- base::GenerateGUID(),
- "abc Device", "XYZ v1", "XYZ SyncAgent v1",
- sync_pb::SyncEnums_DeviceType_TYPE_LINUX);
-
- DeviceInfo device_info2(
- base::GenerateGUID(),
- "def Device", "XYZ v2", "XYZ SyncAgent v2",
- sync_pb::SyncEnums_DeviceType_TYPE_LINUX);
+ DeviceInfo device_info1(base::GenerateGUID(),
+ "abc Device",
+ "XYZ v1",
+ "XYZ SyncAgent v1",
+ sync_pb::SyncEnums_DeviceType_TYPE_LINUX,
+ "device_id");
+
+ DeviceInfo device_info2(base::GenerateGUID(),
+ "def Device",
+ "XYZ v2",
+ "XYZ SyncAgent v2",
+ sync_pb::SyncEnums_DeviceType_TYPE_LINUX,
+ "device_id");
std::vector<DeviceInfo*> devices;
devices.push_back(&device_info1);
@@ -74,10 +78,12 @@ TEST(SignedInDevicesAPITest, GetSignedInDevices) {
// Add a third device and make sure the first 2 ids are retained and a new
// id is generated for the third device.
- DeviceInfo device_info3(
- base::GenerateGUID(),
- "def Device", "jkl v2", "XYZ SyncAgent v2",
- sync_pb::SyncEnums_DeviceType_TYPE_LINUX);
+ DeviceInfo device_info3(base::GenerateGUID(),
+ "def Device",
+ "jkl v2",
+ "XYZ SyncAgent v2",
+ sync_pb::SyncEnums_DeviceType_TYPE_LINUX,
+ "device_id");
devices.push_back(&device_info3);
@@ -132,7 +138,8 @@ DeviceInfo* CreateDeviceInfo(const DeviceInfo& device_info) {
device_info.client_name(),
device_info.chrome_version(),
device_info.sync_user_agent(),
- device_info.device_type());
+ device_info.device_type(),
+ device_info.signin_scoped_device_id());
}
std::string GetPublicId(const base::DictionaryValue* dictionary) {
@@ -168,15 +175,19 @@ TEST_F(ExtensionSignedInDevicesTest, GetAll) {
static_cast<ProfileSyncServiceMockForExtensionTests*>(
ProfileSyncServiceFactory::GetForProfile(profile()));
- DeviceInfo device_info1(
- base::GenerateGUID(),
- "abc Device", "XYZ v1", "XYZ SyncAgent v1",
- sync_pb::SyncEnums_DeviceType_TYPE_LINUX);
-
- DeviceInfo device_info2(
- base::GenerateGUID(),
- "def Device", "XYZ v2", "XYZ SyncAgent v2",
- sync_pb::SyncEnums_DeviceType_TYPE_LINUX);
+ DeviceInfo device_info1(base::GenerateGUID(),
+ "abc Device",
+ "XYZ v1",
+ "XYZ SyncAgent v1",
+ sync_pb::SyncEnums_DeviceType_TYPE_LINUX,
+ "device_id");
+
+ DeviceInfo device_info2(base::GenerateGUID(),
+ "def Device",
+ "XYZ v2",
+ "XYZ SyncAgent v2",
+ sync_pb::SyncEnums_DeviceType_TYPE_LINUX,
+ "device_id");
std::vector<DeviceInfo*> devices;
devices.push_back(CreateDeviceInfo(device_info1));
« no previous file with comments | « chrome/browser/extensions/api/signed_in_devices/id_mapping_helper_unittest.cc ('k') | chrome/browser/sync/glue/device_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698