Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: chrome/browser/sync/glue/synced_device_tracker.cc

Issue 395013002: Pass signin_scoped_device_id to DeviceInfoSpecifics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/synced_device_tracker.cc
diff --git a/chrome/browser/sync/glue/synced_device_tracker.cc b/chrome/browser/sync/glue/synced_device_tracker.cc
index bf7fa9274fc78f9303bb4dd184b690e32702f28f..20220e807c5989cd133e1903b37b366b0160e42d 100644
--- a/chrome/browser/sync/glue/synced_device_tracker.cc
+++ b/chrome/browser/sync/glue/synced_device_tracker.cc
@@ -67,12 +67,13 @@ scoped_ptr<DeviceInfo> SyncedDeviceTracker::ReadLocalDeviceInfo(
}
const sync_pb::DeviceInfoSpecifics& specifics = node.GetDeviceInfoSpecifics();
- return scoped_ptr<DeviceInfo> (
+ return scoped_ptr<DeviceInfo>(
new DeviceInfo(specifics.cache_guid(),
specifics.client_name(),
specifics.chrome_version(),
specifics.sync_user_agent(),
- specifics.device_type()));
+ specifics.device_type(),
+ specifics.signin_scoped_device_id()));
}
scoped_ptr<DeviceInfo> SyncedDeviceTracker::ReadDeviceInfo(
@@ -86,12 +87,13 @@ scoped_ptr<DeviceInfo> SyncedDeviceTracker::ReadDeviceInfo(
}
const sync_pb::DeviceInfoSpecifics& specifics = node.GetDeviceInfoSpecifics();
- return scoped_ptr<DeviceInfo> (
+ return scoped_ptr<DeviceInfo>(
new DeviceInfo(specifics.cache_guid(),
specifics.client_name(),
specifics.chrome_version(),
specifics.sync_user_agent(),
- specifics.device_type()));
+ specifics.device_type(),
+ specifics.signin_scoped_device_id()));
}
void SyncedDeviceTracker::GetAllSyncedDeviceInfo(
@@ -122,12 +124,12 @@ void SyncedDeviceTracker::GetAllSyncedDeviceInfo(
const sync_pb::DeviceInfoSpecifics& specifics =
node.GetDeviceInfoSpecifics();
- device_info->push_back(
- new DeviceInfo(specifics.cache_guid(),
- specifics.client_name(),
- specifics.chrome_version(),
- specifics.sync_user_agent(),
- specifics.device_type()));
+ device_info->push_back(new DeviceInfo(specifics.cache_guid(),
+ specifics.client_name(),
+ specifics.chrome_version(),
+ specifics.sync_user_agent(),
+ specifics.device_type(),
+ specifics.signin_scoped_device_id()));
}
}
@@ -143,11 +145,15 @@ void SyncedDeviceTracker::RemoveObserver(Observer* observer) {
observers_->RemoveObserver(observer);
}
-void SyncedDeviceTracker::InitLocalDeviceInfo(const base::Closure& callback) {
+void SyncedDeviceTracker::InitLocalDeviceInfo(
+ const std::string& signin_scoped_device_id,
+ const base::Closure& callback) {
DeviceInfo::CreateLocalDeviceInfo(
cache_guid_,
+ signin_scoped_device_id,
base::Bind(&SyncedDeviceTracker::InitLocalDeviceInfoContinuation,
- weak_factory_.GetWeakPtr(), callback));
+ weak_factory_.GetWeakPtr(),
+ callback));
}
void SyncedDeviceTracker::InitLocalDeviceInfoContinuation(
@@ -164,6 +170,7 @@ void SyncedDeviceTracker::WriteLocalDeviceInfo(const DeviceInfo& info) {
specifics.set_chrome_version(info.chrome_version());
specifics.set_sync_user_agent(info.sync_user_agent());
specifics.set_device_type(info.device_type());
+ specifics.set_signin_scoped_device_id(info.signin_scoped_device_id());
WriteDeviceInfo(specifics, local_device_info_tag_);
}

Powered by Google App Engine
This is Rietveld 408576698