Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 395006: Turn on shared workers by default (remove --enable-shared-workers, replace with (Closed)

Created:
11 years, 1 month ago by Andrew T Wilson (Slow)
Modified:
9 years, 7 months ago
Reviewers:
jam, dglazkov
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Turn on shared workers by default (remove --enable-shared-workers, replace with --disable-shared-workers). BUG=26223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/renderer_webkitclient_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/worker/worker_uitest.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Andrew T Wilson (Slow)
11 years, 1 month ago (2009-11-13 22:57:13 UTC) #1
jam
Has the security review completed?
11 years, 1 month ago (2009-11-13 23:31:58 UTC) #2
Andrew T Wilson (Slow)
My understanding is this is not necessary. From my previous email with mark larson regarding ...
11 years, 1 month ago (2009-11-14 00:21:25 UTC) #3
jam
11 years, 1 month ago (2009-11-14 01:00:15 UTC) #4
lgtm

for anyone else watching, we're going to start requiring security reviews before
enabling on trunk _after this feature_

Powered by Google App Engine
This is Rietveld 408576698