Bypass android download manager if response is not yet received

Bypass android download manager if response is not yet received

When the InterceptDownloadResourceThrottle intercepts the download request, the response might not have been received yet.
As a result, we are not sure about the mime type and and other file informations.
Using android Download Manager at this stage is premature and risky.
This change bypasses android download manager in this case.

BUG=394092
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283748

[qinmin, 2014-07-15 23:02:52]

PTAL

[David Trainor- moved to gerrit, 2014-07-16 07:48:55]

lgtm

[asanka, 2014-07-16 16:53:10]

https://chromiumcodereview.appspot.com/394993002/diff/1/chrome/browser/androi...
File chrome/browser/android/intercept_download_resource_throttle.cc (right):

https://chromiumcodereview.appspot.com/394993002/diff/1/chrome/browser/androi...
chrome/browser/android/intercept_download_resource_throttle.cc:34:
ProcessDownloadRequest();
This won't do anything now. WillStartRequest is called before
URLRequest::Start() is called. There won't be URLRequest::Job at that point and
hence GetFullRequestHeaders() returns false.

Also URLRequest::GetMimeType() shouldn't be called before the response is ready
(i.e. at or after WillProcessResponse).

https://chromiumcodereview.appspot.com/394993002/diff/1/chrome/browser/androi...
chrome/browser/android/intercept_download_resource_throttle.cc:80:
const_cast<net::URLRequest*>(request_)->GetMimeType(&mime);
Why the const_cast here?

[qinmin, 2014-07-16 17:13:40]

https://chromiumcodereview.appspot.com/394993002/diff/1/chrome/browser/androi...
File chrome/browser/android/intercept_download_resource_throttle.cc (right):

https://chromiumcodereview.appspot.com/394993002/diff/1/chrome/browser/androi...
chrome/browser/android/intercept_download_resource_throttle.cc:34:
ProcessDownloadRequest();
Remove the call to ProcessDownloadRequest here.

On 2014/07/16 16:53:08, asanka wrote:
> This won't do anything now. WillStartRequest is called before
> URLRequest::Start() is called. There won't be URLRequest::Job at that point
and
> hence GetFullRequestHeaders() returns false.
> 
> Also URLRequest::GetMimeType() shouldn't be called before the response is
ready
> (i.e. at or after WillProcessResponse).
>

https://chromiumcodereview.appspot.com/394993002/diff/1/chrome/browser/androi...
chrome/browser/android/intercept_download_resource_throttle.cc:80:
const_cast<net::URLRequest*>(request_)->GetMimeType(&mime);
GetMimeType() was recently changed to a const call.
Removed the const_cast keyword.

On 2014/07/16 16:53:08, asanka wrote:
> Why the const_cast here?

[asanka, 2014-07-16 19:14:19]

LGTM

https://chromiumcodereview.appspot.com/394993002/diff/20001/chrome/browser/an...
File chrome/browser/android/intercept_download_resource_throttle.cc (right):

https://chromiumcodereview.appspot.com/394993002/diff/20001/chrome/browser/an...
chrome/browser/android/intercept_download_resource_throttle.cc:34: }
Nit: You can remove the implementation here and in
intercept_download_resource_throttle.h.

[qinmin, 2014-07-16 19:18:19]

https://chromiumcodereview.appspot.com/394993002/diff/20001/chrome/browser/an...
File chrome/browser/android/intercept_download_resource_throttle.cc (right):

https://chromiumcodereview.appspot.com/394993002/diff/20001/chrome/browser/an...
chrome/browser/android/intercept_download_resource_throttle.cc:34: }
On 2014/07/16 19:14:18, asanka wrote:
> Nit: You can remove the implementation here and in
> intercept_download_resource_throttle.h.

Done.

[qinmin, 2014-07-16 19:18:23]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2014-07-16 19:19:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qinmin@chromium.org/394993002/40001

[commit-bot: I haz the power, 2014-07-17 11:12:43]

Change committed as 283748