Fixing memory leak in DistilledPagePrefs unittests

Fixing memory leak in DistilledPagePrefs unittests

Bug was introduced in r283303.

BUG=383630
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283716

[nyquist, 2014-07-16 16:02:58]

https://codereview.chromium.org/394973004/diff/1/components/dom_distiller/cor...
File components/dom_distiller/core/distilled_page_prefs_unittests.cc (right):

https://codereview.chromium.org/394973004/diff/1/components/dom_distiller/cor...
components/dom_distiller/core/distilled_page_prefs_unittests.cc:48:
TestingObserver obs;
Remove this as an observer here and in the test below. Otherwise the lifetime of
this observer is shorter than the container for the observers.

[smaslo, 2014-07-16 16:06:50]

https://codereview.chromium.org/394973004/diff/1/components/dom_distiller/cor...
File components/dom_distiller/core/distilled_page_prefs_unittests.cc (right):

https://codereview.chromium.org/394973004/diff/1/components/dom_distiller/cor...
components/dom_distiller/core/distilled_page_prefs_unittests.cc:48:
TestingObserver obs;
On 2014/07/16 16:02:57, nyquist wrote:
> Remove this as an observer here and in the test below. Otherwise the lifetime
of
> this observer is shorter than the container for the observers.

Done.

[nyquist, 2014-07-16 16:10:53]

https://codereview.chromium.org/394973004/diff/1/components/dom_distiller/cor...
File components/dom_distiller/core/distilled_page_prefs_unittests.cc (right):

https://codereview.chromium.org/394973004/diff/1/components/dom_distiller/cor...
components/dom_distiller/core/distilled_page_prefs_unittests.cc:40:
scoped_ptr<DistilledPagePrefs> distilled_page_prefs_;
I think the ordering of these two needs to be swapped, since DistilledPagePrefs
depend on TestingPrefServiceSyncable.

[smaslo, 2014-07-16 16:12:51]

https://codereview.chromium.org/394973004/diff/1/components/dom_distiller/cor...
File components/dom_distiller/core/distilled_page_prefs_unittests.cc (right):

https://codereview.chromium.org/394973004/diff/1/components/dom_distiller/cor...
components/dom_distiller/core/distilled_page_prefs_unittests.cc:40:
scoped_ptr<DistilledPagePrefs> distilled_page_prefs_;
On 2014/07/16 16:10:53, nyquist wrote:
> I think the ordering of these two needs to be swapped, since
DistilledPagePrefs
> depend on TestingPrefServiceSyncable.

Done.

[nyquist, 2014-07-16 16:13:11]

lgtm

[smaslo, 2014-07-16 16:23:31]

The CQ bit was checked by smaslo@chromium.org

[smaslo, 2014-07-16 16:24:25]

The CQ bit was unchecked by smaslo@chromium.org

[smaslo, 2014-07-16 16:25:10]

The CQ bit was checked by smaslo@chromium.org

[commit-bot: I haz the power, 2014-07-16 16:26:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/smaslo@chromium.org/394973004/40001

[commit-bot: I haz the power, 2014-07-17 08:37:58]

Change committed as 283716