IDL compiler: void() methods

IDL compiler: void() methods

Initial methods CL!
This just supports void() methods, to keep it simple.

BUG=239771
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160547

[haraken, 2013-10-24 15:59:35]

LGTM

https://codereview.chromium.org/39493002/diff/1/Source/bindings/scripts/unsta...
File Source/bindings/scripts/unstable/v8_interface.py (right):

https://codereview.chromium.org/39493002/diff/1/Source/bindings/scripts/unsta...
Source/bindings/scripts/unstable/v8_interface.py:78: methods_contents,
methods_includes = v8_methods.generate_methods(interface)

Now you can drop |methods_includes|?

https://codereview.chromium.org/39493002/diff/1/Source/bindings/templates/int...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/39493002/diff/1/Source/bindings/templates/int...
Source/bindings/templates/interface.cpp:54: {# FIXME: rename to install_methods
and put into configure_class_template #}

This would be worth doing in a follow-up. We want to keep consistency among
attribute/method/constant installations.

https://codereview.chromium.org/39493002/diff/1/Source/bindings/templates/met...
File Source/bindings/templates/methods.cpp (right):

https://codereview.chromium.org/39493002/diff/1/Source/bindings/templates/met...
Source/bindings/templates/methods.cpp:6: {{method_call(method)}};

method_call => cpp_method (for consistency with cpp_getter, cpp_setter etc)

https://codereview.chromium.org/39493002/diff/1/Source/bindings/templates/met...
Source/bindings/templates/methods.cpp:7: 

Nit: Unnecessary empty line.

https://codereview.chromium.org/39493002/diff/1/Source/bindings/templates/met...
Source/bindings/templates/methods.cpp:8: return;

Nit: Unnecessary return.

https://codereview.chromium.org/39493002/diff/1/Source/bindings/templates/met...
Source/bindings/templates/methods.cpp:14: {% macro method_call(method) %}

Is this worth creating a macro?

[Nils Barth (inactive), 2013-10-25 05:54:24]

(A few followups, esp. cleanup method generation in Perl too.)

https://codereview.chromium.org/39493002/diff/1/Source/bindings/scripts/unsta...
File Source/bindings/scripts/unstable/v8_interface.py (right):

https://codereview.chromium.org/39493002/diff/1/Source/bindings/scripts/unsta...
Source/bindings/scripts/unstable/v8_interface.py:78: methods_contents,
methods_includes = v8_methods.generate_methods(interface)
On 2013/10/24 15:59:36, haraken wrote:
> Now you can drop |methods_includes|?

Yup; this was just temporary, while waiting for the global includes CL to land.
(Rebased and removed.)

https://codereview.chromium.org/39493002/diff/1/Source/bindings/templates/int...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/39493002/diff/1/Source/bindings/templates/int...
Source/bindings/templates/interface.cpp:54: {# FIXME: rename to install_methods
and put into configure_class_template #}
On 2013/10/24 15:59:36, haraken wrote:
> This would be worth doing in a follow-up. We want to keep consistency among
> attribute/method/constant installations.

On my to-do list; that'll help simplify these too.

https://codereview.chromium.org/39493002/diff/1/Source/bindings/templates/met...
File Source/bindings/templates/methods.cpp (right):

https://codereview.chromium.org/39493002/diff/1/Source/bindings/templates/met...
Source/bindings/templates/methods.cpp:6: {{method_call(method)}};
On 2013/10/24 15:59:36, haraken wrote:
> method_call => cpp_method (for consistency with cpp_getter, cpp_setter etc)

Inlined for now, will use this name in future.

https://codereview.chromium.org/39493002/diff/1/Source/bindings/templates/met...
Source/bindings/templates/methods.cpp:7: 
On 2013/10/24 15:59:36, haraken wrote:
> Nit: Unnecessary empty line.

I'll fix this in a followup; Perl has a blank line in void functions instead of
the usual
value statement.

https://codereview.chromium.org/39493002/diff/1/Source/bindings/templates/met...
Source/bindings/templates/methods.cpp:8: return;
On 2013/10/24 15:59:36, haraken wrote:
> Nit: Unnecessary return.

I'll fix in a followup;
Perl has this return, but it looks unnecessary in all cases.

https://codereview.chromium.org/39493002/diff/1/Source/bindings/templates/met...
Source/bindings/templates/methods.cpp:14: {% macro method_call(method) %}
On 2013/10/24 15:59:36, haraken wrote:
> Is this worth creating a macro?

For now inlined.

It will be necessary in future:
it corresponds to Perl GenerateFunctionCallString,
and we have the same code both in the main method control flow
and in the parameter check for optional arguments,
so this avoids duplicating it.
However, we can address it then.

[commit-bot: I haz the power, 2013-10-25 05:54:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/39493002/80001

[commit-bot: I haz the power, 2013-10-25 05:54:56]

Change committed as 160547