Issue 394923005: [mac,win] Enable checking for 64-bit Pepper Flash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 394923005: [mac,win] Enable checking for 64-bit Pepper Flash (Closed)

Created:
6 years, 5 months ago by Scott Hess - ex-Googler

Modified:
6 years, 5 months ago

Reviewers:
cpu_(ooo_6.6-7.5), jschuh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[mac,win] Enable checking for 64-bit Pepper Flash BUG=225777, 179716 TEST=unit tests pass Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284724

Patch Set 1 #

Patch Set 2 : Heck, cover Windows, too. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -15 lines)			Patch
M	chrome/browser/component_updater/test/component_installers_unittest.cc	View	1	2 chunks	+13 lines, -13 lines	0 comments	Download
A +	chrome/test/data/components/flapper/mac_x64/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/test/data/components/flapper/windows_x64/manifest.json	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

Disabling CLs: (mac) https://chromiumcodereview.appspot.com/13472012/ (win) https://chromiumcodereview.appspot.com/12377066 I generated the files by copying their 32-bit version, ...

6 years, 5 months ago (2014-07-21 21:37:18 UTC) #1

Scott Hess - ex-Googler

The CQ bit was checked by shess@chromium.org

6 years, 5 months ago (2014-07-22 16:19:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/394923005/20001

6 years, 5 months ago (2014-07-22 16:20:42 UTC) #4

Message was sent while issue was closed.

Change committed as 284724

Expand Messages | Collapse Messages