Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: mojo/service_manager/background_shell_service_loader_unittest.cc

Issue 394903005: mojo: terminate apps if the shell goes away (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: disable tests that touch nss for now Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/service_manager/background_shell_service_loader_unittest.cc
diff --git a/mojo/service_manager/background_shell_service_loader_unittest.cc b/mojo/service_manager/background_shell_service_loader_unittest.cc
index 4674ccbe3a8f12cc5ab4ce3ddbd817d85e49f583..7469b0f7bb3ab4e2412a3bc805ad4746395012aa 100644
--- a/mojo/service_manager/background_shell_service_loader_unittest.cc
+++ b/mojo/service_manager/background_shell_service_loader_unittest.cc
@@ -52,19 +52,4 @@ TEST(BackgroundShellServiceLoaderTest, Load) {
loader.LoadService(NULL, GURL(), dummy.handle0.Pass());
}
-// Test that an app that doesn't quit itself can still be handled.
-// TODO(tim): Remove this.
-TEST(BackgroundShellServiceLoaderTest, LoadMisbehavedService) {
- scoped_ptr<DummyLoader> real_loader(new DummyLoader());
- real_loader->DontSimulateAppQuit();
- BackgroundShellServiceLoader loader(
- real_loader.PassAs<ServiceLoader>(), "test",
- base::MessageLoop::TYPE_DEFAULT);
- // Because this app is mis-behaved (doesn't quit itself), we need to
- // explicitly kill the thread.
- loader.set_quit_on_shutdown();
- MessagePipe dummy;
- loader.LoadService(NULL, GURL(), dummy.handle0.Pass());
-}
-
} // namespace mojo
« no previous file with comments | « mojo/service_manager/background_shell_service_loader.cc ('k') | mojo/service_manager/service_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698