Source/core/html/forms/TimeInputType.cpp - Issue 394903004: document.lastModified should consider user's local time zone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/TimeInputType.cpp

Issue 394903004: document.lastModified should consider user's local time zone (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix windows build error Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/forms/MonthInputType.cpp ('K') | « Source/core/html/forms/MonthInputType.cpp ('k') | Source/core/html/shadow/DateTimeFieldElements.cpp » ('j') | Source/core/html/shadow/DateTimeFieldElements.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/TimeInputType.cpp

diff --git a/Source/core/html/forms/TimeInputType.cpp b/Source/core/html/forms/TimeInputType.cpp

index f91bf233176d4331c7c43d1bfc2845e2a8e4b20d..4319e63fc0fb3a4e3560e4721780e2151e918b37 100644

--- a/Source/core/html/forms/TimeInputType.cpp

+++ b/Source/core/html/forms/TimeInputType.cpp

@@ -73,12 +73,7 @@ const AtomicString& TimeInputType::formControlType() const

Decimal TimeInputType::defaultValueForStepUp() const

{

- double current = currentTimeMS();

- double utcOffset = calculateUTCOffset();

- double dstOffset = calculateDSTOffset(current, utcOffset);

- int offset = static_cast<int>((utcOffset + dstOffset) / msPerMinute);

- current += offset * msPerMinute;

+ double current = convertToLocalTime(currentTimeMS());

DateComponents date;

date.setMillisecondsSinceMidnight(current);

tkent 2014/07/28 00:40:26 nit: ate.setMillisecondsSinceMidnight(convertToLoc

kangil_ 2014/07/31 00:45:45 Done.

double milliseconds = date.millisecondsSinceEpoch();