Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 394903003: MacViews: Makes a USE_ASH guard in chrome_views_delegate.h match the .cc (Closed)

Created:
6 years, 5 months ago by tapted
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, mac-views-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

MacViews: Makes a USE_ASH guard in chrome_views_delegate.h match the .cc BUG=390755 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/views/chrome_views_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tapted
A small one. This is just to match an existing guard in chrome_views_delegate.cc. But let ...
6 years, 5 months ago (2014-07-17 14:04:28 UTC) #1
sky
LGTM
6 years, 5 months ago (2014-07-17 16:15:32 UTC) #2
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 5 months ago (2014-07-18 00:28:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/394903003/1
6 years, 5 months ago (2014-07-18 00:30:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 01:17:30 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 01:37:41 UTC) #6
Message was sent while issue was closed.
Change committed as 283966

Powered by Google App Engine
This is Rietveld 408576698