Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(256)

Issue 394883008: Add basic perf tests for chromoting protocol. (Closed)

Created:
5 years, 10 months ago by Sergey Ulanov
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add basic perf tests for chromoting protocol. This CL doesn't yet include any emulation of network characteristics (latency, bandwidth, etc.). I'm going to implement it in a separate CL. BUG=394067 TBR=ttuttle@chromium.org (DEPS on net in remoting/test) http://crrev.com/285429

Patch Set 1 #

Total comments: 13

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : DEPS file #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+829 lines, -163 lines) Patch
M remoting/client/chromoting_client.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M remoting/client/chromoting_client.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M remoting/host/client_session.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A remoting/host/fake_desktop_environment.h View 1 2 3 4 5 6 1 chunk +91 lines, -0 lines 0 comments Download
A remoting/host/fake_desktop_environment.cc View 1 chunk +97 lines, -0 lines 0 comments Download
M remoting/host/fake_screen_capturer.h View 2 chunks +11 lines, -16 lines 0 comments Download
M remoting/host/fake_screen_capturer.cc View 1 2 3 4 5 4 chunks +108 lines, -77 lines 0 comments Download
M remoting/host/video_scheduler.h View 2 chunks +5 lines, -1 line 0 comments Download
M remoting/host/video_scheduler.cc View 4 chunks +15 lines, -2 lines 0 comments Download
M remoting/proto/video.proto View 1 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/protocol/channel_multiplexer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/connection_to_host.h View 3 chunks +7 lines, -0 lines 0 comments Download
M remoting/protocol/connection_to_host.cc View 3 chunks +19 lines, -8 lines 0 comments Download
M remoting/remoting_test.gypi View 1 2 3 4 5 6 7 8 chunks +101 lines, -55 lines 0 comments Download
A + remoting/test/DEPS View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -3 lines 0 comments Download
A remoting/test/protocol_perftest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +357 lines, -0 lines 0 comments Download

Messages

Total messages: 42 (0 generated)
Sergey Ulanov
5 years, 10 months ago (2014-07-16 22:22:44 UTC) #1
Wez
https://codereview.chromium.org/394883008/diff/10018/remoting/remoting_test.gypi File remoting/remoting_test.gypi (right): https://codereview.chromium.org/394883008/diff/10018/remoting/remoting_test.gypi#newcode385 remoting/remoting_test.gypi:385: 'test/protocol_perf_test.cc', nit: name this _perftest.cc for consistency?
5 years, 10 months ago (2014-07-16 22:44:52 UTC) #2
rmsousa
https://codereview.chromium.org/394883008/diff/1/remoting/client/chromoting_client.h File remoting/client/chromoting_client.h (right): https://codereview.chromium.org/394883008/diff/1/remoting/client/chromoting_client.h#newcode52 remoting/client/chromoting_client.h:52: void set_candidate_config( is this a testing hook? if so, ...
5 years, 10 months ago (2014-07-16 23:06:00 UTC) #3
Wez
https://codereview.chromium.org/394883008/diff/1/remoting/client/chromoting_client.h File remoting/client/chromoting_client.h (right): https://codereview.chromium.org/394883008/diff/1/remoting/client/chromoting_client.h#newcode52 remoting/client/chromoting_client.h:52: void set_candidate_config( On 2014/07/16 23:06:00, rmsousa wrote: > is ...
5 years, 10 months ago (2014-07-16 23:16:40 UTC) #4
Sergey Ulanov
https://codereview.chromium.org/394883008/diff/1/remoting/client/chromoting_client.h File remoting/client/chromoting_client.h (right): https://codereview.chromium.org/394883008/diff/1/remoting/client/chromoting_client.h#newcode52 remoting/client/chromoting_client.h:52: void set_candidate_config( On 2014/07/16 23:16:39, Wez wrote: > On ...
5 years, 10 months ago (2014-07-17 01:47:59 UTC) #5
Sergey Ulanov
ping
5 years, 10 months ago (2014-07-21 17:45:19 UTC) #6
rmsousa
lgtm
5 years, 10 months ago (2014-07-21 19:53:48 UTC) #7
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
5 years, 10 months ago (2014-07-21 19:56:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/394883008/70001
5 years, 10 months ago (2014-07-21 19:59:14 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
5 years, 10 months ago (2014-07-21 20:17:10 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
5 years, 10 months ago (2014-07-21 20:18:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/31178)
5 years, 10 months ago (2014-07-21 20:18:49 UTC) #12
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
5 years, 10 months ago (2014-07-22 20:37:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/394883008/90001
5 years, 10 months ago (2014-07-22 20:38:30 UTC) #14
Sergey Ulanov
The CQ bit was unchecked by sergeyu@chromium.org
5 years, 10 months ago (2014-07-22 20:43:57 UTC) #15
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
5 years, 10 months ago (2014-07-22 20:51:20 UTC) #16
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
5 years, 10 months ago (2014-07-22 20:52:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/394883008/130001
5 years, 10 months ago (2014-07-22 20:54:28 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
5 years, 10 months ago (2014-07-22 21:40:52 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
5 years, 10 months ago (2014-07-22 21:44:38 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/81597)
5 years, 10 months ago (2014-07-22 21:44:39 UTC) #21
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
5 years, 10 months ago (2014-07-23 00:32:32 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/394883008/150001
5 years, 10 months ago (2014-07-23 00:34:11 UTC) #23
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
5 years, 10 months ago (2014-07-23 02:30:24 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
5 years, 10 months ago (2014-07-23 02:34:42 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/163486) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/209400) chromium_presubmit ...
5 years, 10 months ago (2014-07-23 02:34:43 UTC) #26
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
5 years, 10 months ago (2014-07-24 01:28:55 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/394883008/170001
5 years, 10 months ago (2014-07-24 01:32:30 UTC) #28
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
5 years, 10 months ago (2014-07-24 03:04:53 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/394883008/220001
5 years, 10 months ago (2014-07-24 03:08:53 UTC) #30
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
5 years, 10 months ago (2014-07-24 05:03:57 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
5 years, 10 months ago (2014-07-24 05:09:12 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/81984) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/162267) ios_rel_device_ninja ...
5 years, 10 months ago (2014-07-24 05:09:13 UTC) #33
Sergey Ulanov
+ttuttle in TBR for src/net in remoting/test/DEPS
5 years, 10 months ago (2014-07-24 18:20:18 UTC) #34
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
5 years, 10 months ago (2014-07-24 18:20:26 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/394883008/240001
5 years, 10 months ago (2014-07-24 18:21:58 UTC) #36
Deprecated (see juliatuttle)
On 2014/07/24 18:20:26, Sergey Ulanov wrote: > The CQ bit was checked by mailto:sergeyu@chromium.org lgtm, ...
5 years, 10 months ago (2014-07-24 18:24:22 UTC) #37
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
5 years, 10 months ago (2014-07-24 20:11:20 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/394883008/260001
5 years, 10 months ago (2014-07-24 20:13:39 UTC) #39
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
5 years, 10 months ago (2014-07-24 23:57:48 UTC) #40
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
5 years, 10 months ago (2014-07-25 00:38:38 UTC) #41
commit-bot: I haz the power
5 years, 10 months ago (2014-07-25 00:38:39 UTC) #42
Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

Powered by Google App Engine
This is Rietveld 408576698