Issue 394853002: Make content_shell.exe a console app in ASan/Win builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 394853002: Make content_shell.exe a console app in ASan/Win builds (Closed)

Created:
6 years, 5 months ago by Timur Iskhodzhanov

Modified:
6 years, 5 months ago

Reviewers:
Dirk Pranke, jochen (gone - plz use gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, inferno, jam, jochen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Make content_shell.exe a console app in ASan/Win builds This will help ASan reports appear on stderr when content_shell is run from CMD.exe console or on ClusterFuzz See also http://crrev.com/275067 where the same was applied to chrome.exe BUG=345874 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283551

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	content/content_shell.gypi	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
	M	content/shell/app/shell_main.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Timur Iskhodzhanov

Jochen, Can you please take a look? [+inferno@ just FYI]

6 years, 5 months ago (2014-07-15 15:57:39 UTC) #1

Timur Iskhodzhanov

The CQ bit was checked by timurrrr@chromium.org

6 years, 5 months ago (2014-07-16 13:13:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timurrrr@chromium.org/394853002/20001

6 years, 5 months ago (2014-07-16 13:15:58 UTC) #4

Message was sent while issue was closed.

Change committed as 283551