Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 394763004: Use va_list variable safely (Closed)

Created:
6 years, 5 months ago by qiankun
Modified:
6 years, 5 months ago
Reviewers:
djsollen, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Use va_list variable safely va_list variable will be invalid after the first call. Use va_copy to initialize the va_list for another call. BUG=skia: Committed: https://skia.googlesource.com/skia/+/cd27a41ddafe819fbc597110a50ec9cfadc28c1f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/ports/SkDebug_android.cpp View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qiankun
PTAL.
6 years, 5 months ago (2014-07-15 11:36:02 UTC) #1
djsollen
thanks for catching that. LGTM
6 years, 5 months ago (2014-07-15 12:07:51 UTC) #2
qiankun
The CQ bit was checked by qiankun.miao@intel.com
6 years, 5 months ago (2014-07-15 15:23:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/qiankun.miao@intel.com/394763004/1
6 years, 5 months ago (2014-07-15 15:24:14 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 02:51:45 UTC) #5
Message was sent while issue was closed.
Change committed as cd27a41ddafe819fbc597110a50ec9cfadc28c1f

Powered by Google App Engine
This is Rietveld 408576698