Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 394683002: Use accelerator to switch overview mode (Closed)

Created:
6 years, 5 months ago by oshima
Modified:
6 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Use accelerator to switch overview mode BUG=None R=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283452

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -25 lines) Patch
M athena/wm/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M athena/wm/window_manager_impl.cc View 1 5 chunks +33 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
6 years, 5 months ago (2014-07-14 23:42:04 UTC) #1
sadrul
LGTM https://codereview.chromium.org/394683002/diff/1/athena/wm/window_manager_impl.cc File athena/wm/window_manager_impl.cc (right): https://codereview.chromium.org/394683002/diff/1/athena/wm/window_manager_impl.cc#newcode32 athena/wm/window_manager_impl.cc:32: remove this extra blank line. https://codereview.chromium.org/394683002/diff/1/athena/wm/window_manager_impl.cc#newcode117 athena/wm/window_manager_impl.cc:117: class ...
6 years, 5 months ago (2014-07-15 04:41:39 UTC) #2
oshima
https://codereview.chromium.org/394683002/diff/1/athena/wm/window_manager_impl.cc File athena/wm/window_manager_impl.cc (right): https://codereview.chromium.org/394683002/diff/1/athena/wm/window_manager_impl.cc#newcode32 athena/wm/window_manager_impl.cc:32: On 2014/07/15 04:41:38, sadrul wrote: > remove this extra ...
6 years, 5 months ago (2014-07-15 19:36:19 UTC) #3
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-15 19:37:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/394683002/20001
6 years, 5 months ago (2014-07-15 19:39:27 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:39:29 UTC) #6
Message was sent while issue was closed.
Change committed as 283452

Powered by Google App Engine
This is Rietveld 408576698