Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
394593002:
Roll Android SDK to v20 (Closed)
|
Created:
6 years, 5 months ago by aurimas (slooooooooow) Modified:
6 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionRoll Android SDK to v20
BUG=393019
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283526
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #2 #Patch Set 4 : Update other hardcoded constants #
Total comments: 4
Patch Set 5 : Update gyp constant #
Messages
Total messages: 33 (0 generated)
PTAL
lgtm
The CQ bit was checked by aurimas@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/394593002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was checked by aurimas@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/394593002/20001
The CQ bit was unchecked by aurimas@chromium.org
The CQ bit was checked by aurimas@chromium.org
The CQ bit was checked by aurimas@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/394593002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was checked by aurimas@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/394593002/40001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
cjhopman for GN changes.
https://chromiumcodereview.appspot.com/394593002/diff/60001/DEPS File DEPS (right): https://chromiumcodereview.appspot.com/394593002/diff/60001/DEPS#newcode515 DEPS:515: "@b36620e3a51939055ba871022123221a37ecdebb", Does this roll delete the old build tools? https://chromiumcodereview.appspot.com/394593002/diff/60001/build/android/pyl... File build/android/pylib/constants.py (right): https://chromiumcodereview.appspot.com/394593002/diff/60001/build/android/pyl... build/android/pylib/constants.py:136: ANDROID_SDK_VERSION = 20 This needs to be updated in gyp, too.
https://chromiumcodereview.appspot.com/394593002/diff/60001/DEPS File DEPS (right): https://chromiumcodereview.appspot.com/394593002/diff/60001/DEPS#newcode515 DEPS:515: "@b36620e3a51939055ba871022123221a37ecdebb", On 2014/07/16 16:28:59, cjhopman wrote: > Does this roll delete the old build tools? Yes it does. https://gerrit.chromium.org/gerrit/#/c/70851/ https://chromiumcodereview.appspot.com/394593002/diff/60001/build/android/pyl... File build/android/pylib/constants.py (right): https://chromiumcodereview.appspot.com/394593002/diff/60001/build/android/pyl... build/android/pylib/constants.py:136: ANDROID_SDK_VERSION = 20 On 2014/07/16 16:28:59, cjhopman wrote: > This needs to be updated in gyp, too. Done.
lgtm
brettw@chromium.org: OWNERS review for build/config/android/config.gni
lgtm
The CQ bit was checked by aurimas@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/394593002/80001
The CQ bit was unchecked by aurimas@chromium.org
The CQ bit was checked by aurimas@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/394593002/80001
Message was sent while issue was closed.
Change committed as 283526 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
