Add EF_FINAL_MODIFIERS to suppress remapping.

Add EF_FINAL_MODIFIERS to suppress remapping.

Add EF_FINAL_MODIFIERS to ui::KeyEventFlags to suppress modifier key
remapping on artifical events. This replaces using the X11 send_event
field.

BUG=380349
TEST=EventRewriterTest.TestRewriteKeyEventSentByXSendEvent
R=sadrul@chromium.org,derat@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284085

[kpschoedel, 2014-07-14 17:43:38]

One of several CLs for issue 380349 — Remove exposed dependencies on X11 for
ui::KeyEvent

[Daniel Erat, 2014-07-14 18:07:17]

lgtm, but please wait for sadrul's review

[sadrul, 2014-07-15 04:48:07]

https://codereview.chromium.org/394553002/diff/1/chrome/browser/chromeos/even...
File chrome/browser/chromeos/events/event_rewriter.cc (left):

https://codereview.chromium.org/394553002/diff/1/chrome/browser/chromeos/even...
chrome/browser/chromeos/events/event_rewriter.cc:404: if (!is_send_event) {
Do you not need the check here anymore?

https://codereview.chromium.org/394553002/diff/1/ui/events/x/events_x.cc
File ui/events/x/events_x.cc (right):

https://codereview.chromium.org/394553002/diff/1/ui/events/x/events_x.cc#newc...
ui/events/x/events_x.cc:459: int flags =
GetEventFlagsFromXGenericEvent(native_event);
Update GetEventFlagsFromXKeyEvent() and GetEventFlagsFromXGenericEvent() instead
to set the FINAL flag for send_event.

[kpschoedel, 2014-07-15 14:27:46]

https://codereview.chromium.org/394553002/diff/1/chrome/browser/chromeos/even...
File chrome/browser/chromeos/events/event_rewriter.cc (left):

https://codereview.chromium.org/394553002/diff/1/chrome/browser/chromeos/even...
chrome/browser/chromeos/events/event_rewriter.cc:404: if (!is_send_event) {
On 2014/07/15 04:48:07, sadrul wrote:
> Do you not need the check here anymore?

It was never actually needed here. Before sticky keys was converted, these were
in one block with the, but there are no actual cases affected, and not wrapping
them is more consistent with the name EF_FINAL_MODIFIERS since they don't affect
modifiers.

https://codereview.chromium.org/394553002/diff/1/ui/events/x/events_x.cc
File ui/events/x/events_x.cc (right):

https://codereview.chromium.org/394553002/diff/1/ui/events/x/events_x.cc#newc...
ui/events/x/events_x.cc:459: int flags =
GetEventFlagsFromXGenericEvent(native_event);
On 2014/07/15 04:48:07, sadrul wrote:
> Update GetEventFlagsFromXKeyEvent() and GetEventFlagsFromXGenericEvent()
instead
> to set the FINAL flag for send_event.

Done.

[sadrul, 2014-07-15 22:44:46]

The test failure looks related. Mind taking a look?

[kpschoedel, 2014-07-15 22:51:46]

On 2014/07/15 22:44:46, sadrul wrote:
> The test failure looks related. Mind taking a look?

I'm seeing the same test fail on master when run by hand (but some others do,
too). I'll try another run later and investigate tomorrow if it's still failing.

[sadrul, 2014-07-15 22:54:06]

On 2014/07/15 22:51:46, kpschoedel wrote:
> On 2014/07/15 22:44:46, sadrul wrote:
> > The test failure looks related. Mind taking a look?
> 
> I'm seeing the same test fail on master when run by hand (but some others do,
> too). I'll try another run later and investigate tomorrow if it's still
failing.

OK. Thanks for looking. The changes in the CL LGTM.

[kpschoedel, 2014-07-16 20:18:26]

https://codereview.chromium.org/394553002/diff/1/chrome/browser/chromeos/even...
File chrome/browser/chromeos/events/event_rewriter.cc (left):

https://codereview.chromium.org/394553002/diff/1/chrome/browser/chromeos/even...
chrome/browser/chromeos/events/event_rewriter.cc:404: if (!is_send_event) {
On 2014/07/15 04:48:07, sadrul wrote:
> Do you not need the check here anymore?

It turns out this is necessary; the
KeyboardAccessTest.TestMenuKeyboardOpenDismiss unit test was failing because it
requires a sent event not to be rewritten here.

Renamed the new flag EF_FINAL_MODIFIERS to EF_FINAL, since it turns out not to
be limited to modifiers.

[kpschoedel, 2014-07-17 18:48:37]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-07-17 18:51:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/394553002/40001

[commit-bot: I haz the power, 2014-07-17 22:03:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-17 22:25:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 22:25:52]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[kpschoedel, 2014-07-18 13:59:56]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-07-18 14:02:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/394553002/40001

[commit-bot: I haz the power, 2014-07-18 14:06:15]

Change committed as 284085