Issue 394533003: Include SkTypes before using ifdefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 394533003: Include SkTypes before using ifdefs. (Closed)

Created:
6 years, 5 months ago by scroggo

Modified:
6 years, 5 months ago

Reviewers:
djsollen, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Include SkTypes before using ifdefs. Fixes Android framework build. When building for the Android framework, we depend on SkUserConfig.h to define things like SK_SUPPORT_GPU. So we cannot have the first include inside a guard requring SK_SUPPORT_GPU to be defined. Include SkTypes first, which will pull in SkUserConfig, define the flag, and allow us to include GrContextFactory.h. Committed: https://skia.googlesource.com/skia/+/41b8687417c5f416406366351b1827bfde84265e

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tests/ImageNewShaderTest.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/394533003/20001

6 years, 5 months ago (2014-07-14 17:07:15 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-07-14 17:25:06 UTC) #5

Message was sent while issue was closed.

Change committed as 41b8687417c5f416406366351b1827bfde84265e

Expand Messages | Collapse Messages