Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 394503003: Make chrome_initial dep on crypto32 explicit (Closed)

Created:
6 years, 5 months ago by rlarocque
Modified:
6 years, 5 months ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Make chrome_initial dep on crypto32 explicit Makes the chrome_initial target on Windows depend explicitly on the 'crypto' gyp target and crypt32.dll. These dependency existed previously, but were not made explicit in the build scripts. BUG=393630 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/chrome_exe.gypi View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
rlarocque
While working on a different refactoring, I ran into some build issues that seemed completely ...
6 years, 5 months ago (2014-07-14 17:33:41 UTC) #1
Cait (Slow)
LGTM -- thanks for the catch!
6 years, 5 months ago (2014-07-14 21:06:38 UTC) #2
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 5 months ago (2014-07-14 21:11:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/394503003/1
6 years, 5 months ago (2014-07-14 21:12:34 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 22:17:32 UTC) #5
Message was sent while issue was closed.
Change committed as 283048

Powered by Google App Engine
This is Rietveld 408576698