Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: base/logging.cc

Issue 3945002: Move debug-related stuff from base to the base/debug directory and use the... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/leak_tracker_unittest.cc ('k') | base/process_util_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.cc
===================================================================
--- base/logging.cc (revision 63176)
+++ base/logging.cc (working copy)
@@ -42,7 +42,8 @@
#include "base/base_switches.h"
#include "base/command_line.h"
-#include "base/debug_util.h"
+#include "base/debug/debugger.h"
+#include "base/debug/stack_trace.h"
#include "base/eintr_wrapper.h"
#include "base/lock_impl.h"
#if defined(OS_POSIX)
@@ -220,7 +221,7 @@
#if DEBUG
// Keep the error code for debugging
int error = GetLastError(); // NOLINT
- DebugUtil::BreakDebugger();
+ base::debug::BreakDebugger();
#endif
// Return nicely without putting initialized to true.
return;
@@ -580,7 +581,7 @@
#ifndef NDEBUG
if (severity_ == LOG_FATAL) {
// Include a stack trace on a fatal.
- StackTrace trace;
+ base::debug::StackTrace trace;
stream_ << std::endl; // Newline to separate from log message.
trace.OutputToStream(&stream_);
}
@@ -637,8 +638,8 @@
if (severity_ == LOG_FATAL) {
// display a message or break into the debugger on a fatal error
- if (DebugUtil::BeingDebugged()) {
- DebugUtil::BreakDebugger();
+ if (base::debug::BeingDebugged()) {
+ base::debug::BreakDebugger();
} else {
if (log_assert_handler) {
// make a copy of the string for the handler out of paranoia
@@ -653,7 +654,7 @@
DisplayDebugMessageInDialog(stream_.str());
#endif
// Crash the process to generate a dump.
- DebugUtil::BreakDebugger();
+ base::debug::BreakDebugger();
}
}
} else if (severity_ == LOG_ERROR_REPORT) {
@@ -792,7 +793,7 @@
}
if (level == LOG_FATAL)
- DebugUtil::BreakDebugger();
+ base::debug::BreakDebugger();
}
} // namespace logging
« no previous file with comments | « base/leak_tracker_unittest.cc ('k') | base/process_util_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698