Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2719)

Unified Diff: app/resource_bundle_win.cc

Issue 3945002: Move debug-related stuff from base to the base/debug directory and use the... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/resource_bundle_win.cc
===================================================================
--- app/resource_bundle_win.cc (revision 63176)
+++ app/resource_bundle_win.cc (working copy)
@@ -10,6 +10,7 @@
#include "app/l10n_util.h"
#include "base/data_pack.h"
#include "base/debug_util.h"
+#include "base/debug/stack_trace.h"
#include "base/file_util.h"
#include "base/lock.h"
#include "base/logging.h"
@@ -139,7 +140,7 @@
// If for some reason we were unable to load a resource dll, return an empty
// string (better than crashing).
if (!locale_resources_data_) {
- StackTrace().PrintBacktrace(); // See http://crbug.com/21925.
+ base::debug::StackTrace().PrintBacktrace(); // See http://crbug.com/21925.
LOG(WARNING) << "locale resources are not loaded";
return string16();
}
@@ -156,7 +157,8 @@
image = AtlGetStringResourceImage(_AtlBaseModule.GetModuleInstance(),
message_id);
if (!image) {
- StackTrace().PrintBacktrace(); // See http://crbug.com/21925.
+ // See http://crbug.com/21925.
+ base::debug::StackTrace().PrintBacktrace();
NOTREACHED() << "unable to find resource: " << message_id;
return std::wstring();
}
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698