Revert of Make error messages about private scripts more descriptive

Revert of Make error messages about private scripts more descriptive (https://codereview.chromium.org/389913003/)

Reason for revert:
Speculative revert for telemetry unit tests failing on mac.  Failing tests are tests that deliberately execute scripts that crash the tab. This CL is in the regression range (178046:178054) and seems highly related

Original issue's description:
> Make error messages about private scripts more descriptive
> 
> Instead of just crashing with RELEASE_ASSERT(), we should print more descriptive
> error messages to help debug private scripts.
> 
> BUG=341031
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178046

TBR=arv@chromium.org,abarth@chromium.org,haraken@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=341031

[Justin Novosad, 2014-07-14 15:51:11]

Created Revert of Make error messages about private scripts more descriptive

[commit-bot: I haz the power, 2014-07-14 15:51:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/junov@chromium.org/394493003/1

[commit-bot: I haz the power, 2014-07-14 15:51:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-14 15:51:40]

Failed to apply patch for Source/bindings/core/v8/PrivateScriptRunner.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/core/v8/PrivateScriptRunner.cpp
  Hunk #2 succeeded at 77 with fuzz 2 (offset -16 lines).
  Hunk #3 FAILED at 120.
  Hunk #4 FAILED at 133.
  Hunk #5 succeeded at 138 (offset -8 lines).
  2 out of 5 hunks FAILED -- saving rejects to file
Source/bindings/core/v8/PrivateScriptRunner.cpp.rej

Patch:       Source/bindings/core/v8/PrivateScriptRunner.cpp
Index: Source/bindings/core/v8/PrivateScriptRunner.cpp
diff --git a/Source/bindings/core/v8/PrivateScriptRunner.cpp
b/Source/bindings/core/v8/PrivateScriptRunner.cpp
index
11ab0e21b3ebf0de879375beed14634e8c7ef37c..a089a9987f518e00ef235597531f4a2e9deb0ee2
100644
--- a/Source/bindings/core/v8/PrivateScriptRunner.cpp
+++ b/Source/bindings/core/v8/PrivateScriptRunner.cpp
@@ -37,21 +37,9 @@
         if (className == kPrivateScriptSources[index].name)
             break;
     }
-    if (index == WTF_ARRAY_LENGTH(kPrivateScriptSources)) {
-        FATAL("Private script error: Target source code was not found. (Class
name = %s)\n", className.utf8().data());
-        RELEASE_ASSERT_NOT_REACHED();
-    }
-
-    v8::TryCatch block;
+    RELEASE_ASSERT(index != WTF_ARRAY_LENGTH(kPrivateScriptSources));
     String source(reinterpret_cast<const
char*>(kPrivateScriptSources[index].source), kPrivateScriptSources[index].size);
-    v8::Handle<v8::Value> result =
V8ScriptRunner::compileAndRunInternalScript(v8String(isolate, source), isolate);
-    if (block.HasCaught()) {
-        FATAL("Private script error: Compile failed. (Class name = %s)\n",
className.utf8().data());
-        if (!block.Message().IsEmpty())
-            FATAL("%s\n", toCoreString(block.Message()->Get()).utf8().data());
-        RELEASE_ASSERT_NOT_REACHED();
-    }
-    return result;
+    return V8ScriptRunner::compileAndRunInternalScript(v8String(isolate,
source), isolate);
 }
 
 static v8::Handle<v8::Object> classObjectOfPrivateScript(ScriptState*
scriptState, String className)
@@ -105,14 +93,7 @@
     if (isInitialized.IsEmpty()) {
         v8::Handle<v8::Value> initializeFunction =
classObject->Get(v8String(isolate, "constructor"));
         if (!initializeFunction.IsEmpty() && initializeFunction->IsFunction())
{
-            v8::TryCatch block;
            
V8ScriptRunner::callFunction(v8::Handle<v8::Function>::Cast(initializeFunction),
scriptState->executionContext(), holder, 0, 0, isolate);
-            if (block.HasCaught()) {
-                FATAL("Private script error: Object constructor threw an
exception.\n");
-                if (!block.Message().IsEmpty())
-                    FATAL("%s\n",
toCoreString(block.Message()->Get()).utf8().data());
-                RELEASE_ASSERT_NOT_REACHED();
-            }
         }
         isInitialized = v8Boolean(true, isolate);
         V8HiddenValue::setHiddenValue(isolate, holderObject,
V8HiddenValue::privateScriptObjectIsInitialized(isolate), isInitialized);
@@ -139,10 +120,8 @@
     v8::Handle<v8::Object> classObject =
classObjectOfPrivateScript(scriptState, className);
     v8::Handle<v8::Object> descriptor = getOwnPropertyDescriptor(scriptState,
classObject, attributeName);
     v8::Handle<v8::Value> getter =
descriptor->Get(v8String(scriptState->isolate(), "get"));
-    if (getter.IsEmpty() || !getter->IsFunction()) {
-        FATAL("Private script error: Target DOM attribute getter was not found.
(Class name = %s, Attribute name = %s)\n", className.utf8().data(),
attributeName.utf8().data());
-        RELEASE_ASSERT_NOT_REACHED();
-    }
+    RELEASE_ASSERT(!getter.IsEmpty());
+    RELEASE_ASSERT(getter->IsFunction());
     initializeHolderIfNeeded(scriptState, classObject, holder);
     return V8ScriptRunner::callFunction(v8::Handle<v8::Function>::Cast(getter),
scriptState->executionContext(), holder, 0, 0, scriptState->isolate());
 }
@@ -152,10 +131,8 @@
     v8::Handle<v8::Object> classObject =
classObjectOfPrivateScript(scriptState, className);
     v8::Handle<v8::Object> descriptor = getOwnPropertyDescriptor(scriptState,
classObject, attributeName);
     v8::Handle<v8::Value> setter =
descriptor->Get(v8String(scriptState->isolate(), "set"));
-    if (setter.IsEmpty() || !setter->IsFunction()) {
-        FATAL("Private script error: Target DOM attribute setter was not found.
(Class name = %s, Attribute name = %s)\n", className.utf8().data(),
attributeName.utf8().data());
-        RELEASE_ASSERT_NOT_REACHED();
-    }
+    RELEASE_ASSERT(!setter.IsEmpty());
+    RELEASE_ASSERT(setter->IsFunction());
     initializeHolderIfNeeded(scriptState, classObject, holder);
     v8::Handle<v8::Value> argv[] = { v8Value };
     V8ScriptRunner::callFunction(v8::Handle<v8::Function>::Cast(setter),
scriptState->executionContext(), holder, WTF_ARRAY_LENGTH(argv), argv,
scriptState->isolate());
@@ -165,10 +142,8 @@
 {
     v8::Handle<v8::Object> classObject =
classObjectOfPrivateScript(scriptState, className);
     v8::Handle<v8::Value> method =
classObject->Get(v8String(scriptState->isolate(), methodName));
-    if (method.IsEmpty() || !method->IsFunction()) {
-        FATAL("Private script error: Target DOM method was not found. (Class
name = %s, Method name = %s)\n", className.utf8().data(),
methodName.utf8().data());
-        RELEASE_ASSERT_NOT_REACHED();
-    }
+    RELEASE_ASSERT(!method.IsEmpty());
+    RELEASE_ASSERT(method->IsFunction());
     initializeHolderIfNeeded(scriptState, classObject, holder);
     return V8ScriptRunner::callFunction(v8::Handle<v8::Function>::Cast(method),
scriptState->executionContext(), holder, argc, argv, scriptState->isolate());
 }

[Justin Novosad, 2014-07-14 16:07:31]

It is good that this revert failed. Just got results from the win7 bot which
narrowed the regression range and excludes this rev form the blamelist. 
Closing...