Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 394463004: Use the NavigatorContentUtils guard for unregisterProtocolHandler (Closed)

Created:
6 years, 5 months ago by gyuyoung-inactive
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, gyuyoung.kim_webkit.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use NavigatorContentUtils guard for unregisterProtocolHandler() As unregisterProtocolHandler() is shipped, it would be good to use NavigatorContentUtils REF for it. BUG=392016 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/navigatorcontentutils/NavigatorContentUtils.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
gyuyoung-inactive
As I said on blink-dev thread, I'd like to let unregisterProtocolHandler use NavigatorContentUtils guard instead ...
6 years, 5 months ago (2014-07-15 01:06:26 UTC) #1
gyuyoung-inactive
On 2014/07/15 01:06:26, gyuyoung wrote: PTAL.
6 years, 5 months ago (2014-07-15 04:00:41 UTC) #2
gyuyoung-inactive
Add haraken to reviewer
6 years, 5 months ago (2014-07-16 03:44:25 UTC) #3
haraken
Given the LGTM on the blink-dev thread, LGTM.
6 years, 5 months ago (2014-07-16 03:50:54 UTC) #4
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-16 03:54:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/394463004/1
6 years, 5 months ago (2014-07-16 03:55:16 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 04:57:07 UTC) #7
Message was sent while issue was closed.
Change committed as 178241

Powered by Google App Engine
This is Rietveld 408576698