Source/core/html/imports/HTMLImport.cpp - Issue 394463003: Oilpan: have HTMLImport::recalcTreeState() use on-heap local variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/imports/HTMLImport.cpp

Issue 394463003: Oilpan: have HTMLImport::recalcTreeState() use on-heap local variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/imports/HTMLImport.cpp

diff --git a/Source/core/html/imports/HTMLImport.cpp b/Source/core/html/imports/HTMLImport.cpp

index 4726f7132355c1c9006e6bc4d2adb695e1ec7cc4..58b17f75c752f8676a28b3de89d3e0fc83faed20 100644

--- a/Source/core/html/imports/HTMLImport.cpp

+++ b/Source/core/html/imports/HTMLImport.cpp

@@ -87,8 +87,8 @@ void HTMLImport::stateDidChange()

void HTMLImport::recalcTreeState(HTMLImport* root)

{

- HashMap<HTMLImport*, HTMLImportState> snapshot;

- Vector<HTMLImport*> updated;

+ WillBeHeapHashMap<RawPtrWillBeMember<HTMLImport>, HTMLImportState> snapshot;

+ WillBeHeapVector<RawPtrWillBeMember<HTMLImport> > updated;

for (HTMLImport* i = root; i; i = traverseNext(i)) {

snapshot.add(i, i->state());

« no previous file with comments | « no previous file | no next file » | no next file with comments »