Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1435)

Issue 394463003: Oilpan: have HTMLImport::recalcTreeState() use on-heap local variables. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: have HTMLImport::recalcTreeState() use on-heap local variables. R=wibling@chromium.org,haraken@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/html/imports/HTMLImport.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-07-14 14:45:48 UTC) #1
wibling-chromium
lgtm
6 years, 5 months ago (2014-07-14 14:47:52 UTC) #2
haraken
LGTM
6 years, 5 months ago (2014-07-14 15:05:13 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-14 15:11:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/394463003/1
6 years, 5 months ago (2014-07-14 15:11:57 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-14 16:14:30 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 17:03:57 UTC) #7
Message was sent while issue was closed.
Change committed as 178078

Powered by Google App Engine
This is Rietveld 408576698