Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 394423002: [Telemetry] Fix a flake in android browser finder. (Closed)

Created:
6 years, 5 months ago by tonyg
Modified:
6 years, 5 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix a flake in android browser finder. Traceback (most recent call last): File "tools/perf/../telemetry/telemetry/decorators.py", line 50, in wrapper func(*args, **kwargs) File "/b/build/slave/Android_Tests/build/src/tools/perf/benchmarks/benchmark_unittest.py", line 51, in BenchmarkSmokeTest self.assertEqual(0, SinglePageBenchmark().Run(options), File "tools/perf/../telemetry/telemetry/benchmark.py", line 84, in Run results = page_runner.Run(test, ps, expectations, args) File "tools/perf/../telemetry/telemetry/page/page_runner.py", line 346, in Run possible_browser = browser_finder.FindBrowser(finder_options) File "tools/perf/../telemetry/telemetry/decorators.py", line 26, in Cacher cache[key] = obj(*args, **kwargs) File "tools/perf/../telemetry/telemetry/core/browser_finder.py", line 73, in FindBrowser curr_browsers = finder.FindAllAvailableBrowsers(options) File "tools/perf/../telemetry/telemetry/core/backends/chrome/android_browser_finder.py", line 214, in FindAllAvailableBrowsers pids = [p.pid for p in psutil.process_iter() if 'adb' in p.name] File "/usr/lib/python2.7/dist-packages/psutil/__init__.py", line 161, in name cmdline = self.cmdline File "/usr/lib/python2.7/dist-packages/psutil/__init__.py", line 188, in cmdline return self._platform_impl.get_process_cmdline() File "/usr/lib/python2.7/dist-packages/psutil/_pslinux.py", line 327, in wrapper raise NoSuchProcess(self.pid, self._process_name) NoSuchProcess: process no longer exists (pid=13764) Observed here: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14626/steps/telemetry_perf_unittests/logs/stdio BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284144

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : make windows happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 2 3 2 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tonyg
6 years, 5 months ago (2014-07-17 02:06:00 UTC) #1
dtu
lgtm
6 years, 5 months ago (2014-07-18 03:00:51 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 5 months ago (2014-07-18 04:23:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/394423002/40001
6 years, 5 months ago (2014-07-18 04:25:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 05:43:54 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 06:37:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/32068)
6 years, 5 months ago (2014-07-18 06:37:46 UTC) #7
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 5 months ago (2014-07-18 15:35:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/394423002/60001
6 years, 5 months ago (2014-07-18 15:36:51 UTC) #9
commit-bot: I haz the power
Change committed as 284144
6 years, 5 months ago (2014-07-18 17:40:08 UTC) #10
tonyg
6 years, 5 months ago (2014-07-18 20:05:34 UTC) #11
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/407633002/ by tonyg@chromium.org.

The reason for reverting is: BUG=395228.

Powered by Google App Engine
This is Rietveld 408576698