chrome/browser/ui/passwords/manage_passwords_bubble_model.h - Issue 394403003: Close the password bubble on the icon click.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.h

Issue 394403003: Close the password bubble on the icon click. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed the unnecessary command Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.h

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h

index e6ae6aad411751f65a901fa92cd771fbf5def1d2..1435bb58e7fe010173ae1cf6990b0fc4b0456036 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h

@@ -88,6 +88,8 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {

void set_state(password_manager::ui::State state) { state_ = state; }

#endif

+ using content::WebContentsObserver::web_contents;

Mike West 2014/07/22 12:08:40 Nit: This seems unnecessary?

vasilii 2014/07/22 14:18:51 I'm bringing it to the public scope. I use it in S

private:

password_manager::ui::State state_;

base::string16 title_;