chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc - Issue 394403003: Close the password bubble on the icon click.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

Issue 394403003: Close the password bubble on the icon click. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added a test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('K') | « chrome/browser/ui/views/passwords/manage_passwords_icon_view.h ('k') | chrome/browser/ui/views/passwords/manage_passwords_icon_view_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/passwords/manage_passwords_icon_view.h"	5 #include "chrome/browser/ui/views/passwords/manage_passwords_icon_view.h"

6	6

7 #include "chrome/app/chrome_command_ids.h"	7 #include "chrome/app/chrome_command_ids.h"

8 #include "chrome/browser/command_updater.h"	8 #include "chrome/browser/command_updater.h"

9 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"	9 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"

10 #include "chrome/browser/ui/view_ids.h"	10 #include "chrome/browser/ui/view_ids.h"

(...skipping 50 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
61 }	61 }

62 }	62 }

63	63

64 bool ManagePasswordsIconView::IsBubbleShowing() const {	64 bool ManagePasswordsIconView::IsBubbleShowing() const {

65 return ManagePasswordsBubbleView::IsShowing();	65 return ManagePasswordsBubbleView::IsShowing();

66 }	66 }

67	67

68 void ManagePasswordsIconView::OnExecuting(	68 void ManagePasswordsIconView::OnExecuting(

69 BubbleIconView::ExecuteSource source) {	69 BubbleIconView::ExecuteSource source) {

70 }	70 }

	71

	72 void ManagePasswordsIconView::OnMousePressSuppressed() {
	Peter Kasting 2014/07/22 18:55:18 Instead of adding a new virtual method with the so Instead of adding a new virtual method with the somewhat confusing name of OnMousePressSuppressed(), why not just override OnMousePressed() in this class, have it call the superclass method to set the \|suppress_mouse_released_action_\| variable correctly, then call CloseBubble()? vasilii 2014/07/23 09:22:53 Done. Show quoted text On 2014/07/22 18:55:18, Peter Kasting wrote: > Instead of adding a new virtual method with the somewhat confusing name of > OnMousePressSuppressed(), why not just override OnMousePressed() in this class, > have it call the superclass method to set the \|suppress_mouse_released_action_\| > variable correctly, then call CloseBubble()? Done.
	73 ManagePasswordsBubbleView::CloseBubble();

	74 }

OLD	NEW