Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.h

Issue 394403003: Close the password bubble on the icon click. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed the unnecessary command Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_H_
7 7
8 #include "ui/views/controls/image_view.h" 8 #include "ui/views/controls/image_view.h"
9 9
10 class CommandUpdater; 10 class CommandUpdater;
11 11
12 // Represents an icon on the omnibox that shows a bubble when clicked. 12 // Represents an icon on the omnibox that shows a bubble when clicked.
13 class BubbleIconView : public views::ImageView { 13 class BubbleIconView : public views::ImageView {
14 protected: 14 protected:
15 enum ExecuteSource { 15 enum ExecuteSource {
16 EXECUTE_SOURCE_MOUSE, 16 EXECUTE_SOURCE_MOUSE,
17 EXECUTE_SOURCE_KEYBOARD, 17 EXECUTE_SOURCE_KEYBOARD,
18 EXECUTE_SOURCE_GESTURE, 18 EXECUTE_SOURCE_GESTURE,
19 }; 19 };
20 20
21 explicit BubbleIconView(CommandUpdater* command_updater, int command_id); 21 explicit BubbleIconView(CommandUpdater* command_updater, int command_id);
22 virtual ~BubbleIconView(); 22 virtual ~BubbleIconView();
23 23
24 // Returns true if a related bubble is showing. 24 // Returns true if a related bubble is showing.
25 virtual bool IsBubbleShowing() const = 0; 25 virtual bool IsBubbleShowing() const = 0;
26 26
27 // Invoked prior to executing the command. 27 // Invoked prior to executing the command.
28 virtual void OnExecuting(ExecuteSource execute_source) = 0; 28 virtual void OnExecuting(ExecuteSource execute_source) = 0;
29 29
30 // Invoked when the mouse pressed event is ignored.
31 virtual void OnMousePressedIgnored() {}
Mike West 2014/07/22 12:08:40 Nit: How about 'OnMousePressSuppressed()' for cons
vasilii 2014/07/22 14:18:51 Done.
32
30 // views::ImageView: 33 // views::ImageView:
31 virtual void GetAccessibleState(ui::AXViewState* state) OVERRIDE; 34 virtual void GetAccessibleState(ui::AXViewState* state) OVERRIDE;
32 virtual bool GetTooltipText(const gfx::Point& p, base::string16* tooltip) 35 virtual bool GetTooltipText(const gfx::Point& p, base::string16* tooltip)
33 const OVERRIDE; 36 const OVERRIDE;
34 virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE; 37 virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE;
35 virtual void OnMouseReleased(const ui::MouseEvent& event) OVERRIDE; 38 virtual void OnMouseReleased(const ui::MouseEvent& event) OVERRIDE;
36 virtual bool OnKeyPressed(const ui::KeyEvent& event) OVERRIDE; 39 virtual bool OnKeyPressed(const ui::KeyEvent& event) OVERRIDE;
37 40
38 // ui::EventHandler: 41 // ui::EventHandler:
39 virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE; 42 virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE;
40 43
41 private: 44 private:
42 // The CommandUpdater for the Browser object that owns the location bar. 45 // The CommandUpdater for the Browser object that owns the location bar.
43 CommandUpdater* command_updater_; 46 CommandUpdater* command_updater_;
44 47
45 // The command ID executed when the user clicks this icon. 48 // The command ID executed when the user clicks this icon.
46 const int command_id_; 49 const int command_id_;
47 50
48 // This is used to check if the bookmark bubble was showing during the mouse 51 // This is used to check if the bookmark bubble was showing during the mouse
49 // pressed event. If this is true then the mouse released event is ignored to 52 // pressed event. If this is true then the mouse released event is ignored to
50 // prevent the bubble from reshowing. 53 // prevent the bubble from reshowing.
51 bool suppress_mouse_released_action_; 54 bool suppress_mouse_released_action_;
52 55
53 DISALLOW_COPY_AND_ASSIGN(BubbleIconView); 56 DISALLOW_COPY_AND_ASSIGN(BubbleIconView);
54 }; 57 };
55 58
56 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_H_ 59 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698